k8s.io icon indicating copy to clipboard operation
k8s.io copied to clipboard

[EKS Prow Cluster] Add karpenter terraform module for eks-prow-build cluster

Open koksay opened this issue 1 year ago • 2 comments
trafficstars

  • Add karpenter module, which creates related roles, sqs queue and events
  • Update EKSAdmin role to be able to create above resources
  • Add manually added SSO role to terraform

Make sure to update the serviceAccount.annotations field in the infra/aws/terraform/prow-build-cluster/resources/karpenter/flux-hr-karpenter.yaml file (also in infra/aws/terraform/prow-build-cluster/resources/karpenter/prod-cluster-values):

# You may use this command to get the arn after terraform apply:
terraform state show module.karpenter.aws_iam_role.controller\[0\] | grep " arn "

There will be a follow-up PR to add nodepool and nodeclass configration.

koksay avatar Jun 14 '24 14:06 koksay

/assign @xmudrii

koksay avatar Jun 14 '24 14:06 koksay

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: koksay Once this PR has been reviewed and has the lgtm label, please ask for approval from xmudrii. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 14 '24 14:06 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 24 '24 04:07 k8s-ci-robot

/hold Until we don't decide on https://github.com/kubernetes/k8s.io/pull/7062

@koksay I worked on this PR locally and fixed most of the comments, I'll see how can I push those changes or eventually create a new PR if that's okay

xmudrii avatar Jul 24 '24 13:07 xmudrii

Superseded by #7063

xmudrii avatar Jul 29 '24 12:07 xmudrii

/close

xmudrii avatar Jul 29 '24 12:07 xmudrii

@xmudrii: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 29 '24 12:07 k8s-ci-robot