k8s.io
k8s.io copied to clipboard
kubernetes
Allow kgolab to write to k8s-staging-autoscaling GCR
Reason: to help with releases, in particular to release new Addon Resizer for https://github.com/kubernetes/autoscaler/pull/5234.
Welcome @kgolab!
It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/k8s.io has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @kgolab. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing
/verify-ownersin a comment.
kgolab
- User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
Not sure if this helps any but I'm both reviewer & approver under k/autoscaler/vertical-pod-autoscaler/OWNERS.
k/autoscaler/vertical-pod-autoscaler/OWNERS
Can you open an membership request in https://github.com/kubernetes/org/issues/new/choose ? Since you have a large number of contributions, process should be quick.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kgolab, mwielgus
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~groups/sig-autoscaling/OWNERS~~ [mwielgus]
- ~~k8s.gcr.io/images/k8s-staging-autoscaling/OWNERS~~ [mwielgus]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment