k8s.io icon indicating copy to clipboard operation
k8s.io copied to clipboard

Refactor GSuite Groups Reconciler Application

Open upodroid opened this issue 3 years ago • 3 comments

Hello

I'm a contributor with Knative and we have implemented the GSuite Groups Reconciler at https://github.com/knative/community/pull/905. However, this package has hardcoded references to kubernetes.io, critical validation is done go test instead of a cli sub command which forced us to clone the code and replace k8s specific references instead of go install k8s.io/k8s.io/[email protected].

I'm proposing:

  • groups validate command - equivalent to make test
  • groups plan command - equivalent to make run
  • groups apply command - equivalent to make run -- --confirm
  • Make the domain configurable through config.yaml

Thank you

/cc @dims @dprotaso

upodroid avatar Feb 04 '22 16:02 upodroid

@upodroid sounds like the right thing to do. Hoping these are minimal changes since we have a bunch of things we'll need to fix and this is already "production" code for us.

dims avatar Feb 04 '22 17:02 dims

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 05 '22 17:05 k8s-triage-robot

/lifecycle frozen

dprotaso avatar May 05 '22 17:05 dprotaso