Refactor GSuite Groups Reconciler Application
Hello
I'm a contributor with Knative and we have implemented the GSuite Groups Reconciler at https://github.com/knative/community/pull/905. However, this package has hardcoded references to kubernetes.io, critical validation is done go test instead of a cli sub command which forced us to clone the code and replace k8s specific references instead of go install k8s.io/k8s.io/[email protected].
I'm proposing:
groups validatecommand - equivalent tomake testgroups plancommand - equivalent tomake rungroups applycommand - equivalent tomake run -- --confirm- Make the domain configurable through config.yaml
Thank you
/cc @dims @dprotaso
@upodroid sounds like the right thing to do. Hoping these are minimal changes since we have a bunch of things we'll need to fix and this is already "production" code for us.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/lifecycle frozen