k8s.io icon indicating copy to clipboard operation
k8s.io copied to clipboard

k8s.io: test.py isn't exercised during presubmit

Open spiffxp opened this issue 3 years ago • 5 comments

This allows people such as myself (who definitely like seeing tests pass, but rely on CI to run all the things) to merge PR's that pass presubmits, but will fail to deploy.

e.g. https://github.com/kubernetes/k8s.io/pull/2334 went through multiple eyes for review, everyone thought it looked great... and then I needed to followup with https://github.com/kubernetes/k8s.io/pull/2347

I'm not sure if the solution is to standup a local nginx, pull the redirect spec out such that there's less copy-paste between the config and the tests, or something else.

/wg k8s-infra /sig contributor-experience /kind bug /priority important-longterm

spiffxp avatar Jul 15 '21 23:07 spiffxp

hi @spiffxp I would like to work on this.

rajibmitra avatar Sep 04 '21 18:09 rajibmitra

please do! :-) you don't have to ask to work on something.

BenTheElder avatar Oct 13 '21 21:10 BenTheElder

/assign @rajibmitra

MadhavJivrajani avatar Oct 21 '21 12:10 MadhavJivrajani

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 19 '22 13:01 k8s-triage-robot

/lifecycle frozen

BenTheElder avatar Jan 21 '22 21:01 BenTheElder