k8s.io icon indicating copy to clipboard operation
k8s.io copied to clipboard

Prow: allow deployment of kubernetes-external-secrets without roles/container.admin

Open spiffxp opened this issue 3 years ago • 16 comments

Should be able to CRUD kubernetes resources without CRUD rights for the cluster

Some work has already been done toward this, to link in later

spiffxp avatar Jun 15 '21 17:06 spiffxp

/area prow /area cluster-infra /sig testing /wg k8s-infra /priority important-longterm

spiffxp avatar Jun 30 '21 15:06 spiffxp

https://github.com/kubernetes/k8s.io/pull/2190 setup a custom container.deployer role

But that apparently still isn't sufficient: https://github.com/kubernetes/k8s.io/pull/2190#issuecomment-859750534

spiffxp avatar Jun 30 '21 15:06 spiffxp

/milestone v1.23

spiffxp avatar Jul 16 '21 18:07 spiffxp

It seems like creating RBAC-related resources is the sticking point here. I suspect container.admin is by default given a Kubernetes role that allows it to do so, but custom roles maybe not so much?

spiffxp avatar Jul 30 '21 15:07 spiffxp

/milestone v1.22 If I can't figure out what's preventing the custom role I'm going to add back container.admin for now to unblock auto-deploys

spiffxp avatar Jul 30 '21 15:07 spiffxp

/milestone v1.23

spiffxp avatar Aug 03 '21 16:08 spiffxp

Went back to roles/container.admin for now

spiffxp avatar Aug 06 '21 18:08 spiffxp

/remove-priority important-longterm /priority backlog /milestone clear

spiffxp avatar Sep 29 '21 19:09 spiffxp

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 28 '21 22:12 k8s-triage-robot

/remove-lifecycle stale

ameukam avatar Jan 03 '22 19:01 ameukam

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 03 '22 19:04 k8s-triage-robot

/remove-lifecycle stale

ameukam avatar Apr 04 '22 14:04 ameukam

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 03 '22 14:07 k8s-triage-robot

/remove-lifecycle stale

ameukam avatar Jul 04 '22 06:07 ameukam

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 02 '22 07:10 k8s-triage-robot

/remove-lifecycle stale /lifecycle frozen

ameukam avatar Oct 03 '22 08:10 ameukam