ingress-nginx
ingress-nginx copied to clipboard
Clean out Ingress field in store.Lister struct
This field isn't used anywhere. The ingresses are actually stored alongside their parsed annotations in the IngressWithAnnotation field.
This issue is currently awaiting triage.
If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi @dud225. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test
@dud225 Can you please rebase over main, and retest?
Thanks!
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dud225 Once this PR has been reviewed and has the lgtm label, please assign tao12345666333 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Deploy Preview for kubernetes-ingress-nginx ready!
| Name | Link |
|---|---|
| Latest commit | aa4106191d402aa249106d05dddeea2cce456fe6 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65e05bd7d4d1a6000898cb70 |
| Deploy Preview | https://deploy-preview-9537--kubernetes-ingress-nginx.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@rikatz done
hum I think the rebase didn't worked, the label is still there conflicting.
@rikatz I've rebased again over main it should be good now :pray:
@dud225 can you rebase and retest for us, trying to clean up open issues and PRs
/uncc