ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

added e2e tests for complex regex paths

Open swapnild2 opened this issue 2 years ago • 8 comments

added e2e tests for complex regex paths

What this PR does / why we need it:

(https://github.com/kubernetes/ingress-nginx/issues/9466)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] CVE Report (Scanner found CVE and adding report)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation only

Which issue/s this PR fixes

fixes #9466

How Has This Been Tested?

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ x] I've read the CONTRIBUTION guide
  • [ ] I have added unit and/or e2e tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

  • CLI change
  • API change
  • UI change
  • configuration schema change
  • behavioral change
  • change in non-functional attributes such as efficiency or availability, availability of a new platform
  • a warning about a deprecation
  • fix of a previous Known Issue
  • fix of a vulnerability (CVE)

No release notes are required for changes to the following:

  • Tests
  • Build infrastructure
  • Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

NONE

swapnild2 avatar Jan 21 '23 19:01 swapnild2

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: rikatz / name: Ricardo Katz (4f236d3deb5cc4f3fba378a455d2a7fae62e942d)
  • :white_check_mark: login: swapnild2 (56de5ea4705945081f530203317e2a9c0f1569d8)

Welcome @swapnild2!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jan 21 '23 19:01 k8s-ci-robot

Hi @swapnild2. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 21 '23 19:01 k8s-ci-robot

@swapnild2 it seems like the E2E tests did not pass for this @longwuyuan can we rerun them as the logs have expired

Spazzy757 avatar May 16 '23 08:05 Spazzy757

/retest

longwuyuan avatar May 16 '23 08:05 longwuyuan

/ok-to-test /check-cla /priority backlog /triage accepted

strongjz avatar Mar 29 '24 12:03 strongjz

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swapnild2 Once this PR has been reviewed and has the lgtm label, please assign gacko for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 22 '24 22:08 k8s-ci-robot

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
Latest commit 4f236d3deb5cc4f3fba378a455d2a7fae62e942d
Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66c7ba88e9694a0008afe2d8

netlify[bot] avatar Aug 22 '24 22:08 netlify[bot]

/uncc

rikatz avatar Aug 15 '25 13:08 rikatz