ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

adding cve finding and adding release-notes to PR template

Open strongjz opened this issue 3 years ago • 3 comments

Signed-off-by: James Strong [email protected]

What this PR does / why we need it:

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [X] Documentation only

Which issue/s this PR fixes

The first step of automating releases #8734

Checklist:

  • [X] My change requires a change to the documentation.
  • [X] I have updated the documentation accordingly.
  • [X] I've read the CONTRIBUTION guide
  • [X] I have added tests to cover my changes.
  • [X] All new and existing tests passed.

strongjz avatar Aug 09 '22 17:08 strongjz

/kind feature /triage accepted /area stablization /priority backlog

strongjz avatar Aug 09 '22 17:08 strongjz

@strongjz: The label(s) area/stablization cannot be applied, because the repository doesn't have them.

In response to this:

/kind feature /triage accepted /area stablization /priority backlog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 09 '22 17:08 k8s-ci-robot

/lgtm

longwuyuan avatar Aug 25 '22 02:08 longwuyuan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 25 '22 02:08 k8s-ci-robot