ingress-nginx
ingress-nginx copied to clipboard
kubernetes
keep-alive ConfigMap option must be integer number of seconds
At present the documentation for keep-alive is rather vague as to its type or unit.
Sets the time during which a keep-alive client connection will stay open on the server side. The zero value disables keep-alive client connections.
In fact the nginx documentation it references for keepalive_timeout shows it with a unit suffix, as in Go's time.ParseDuration.
Default:
keepalive_timeout 75s;
From the source code of ingress-nginx, apparently it expects keep-alive to always be an integer number of seconds.
https://github.com/kubernetes/ingress-nginx/blob/f44e79002176a0d6585a22334d72d74f2e936563/rootfs/etc/nginx/template/nginx.tmpl#L288
The ingress-nginx documentation needs to be amended to state this explicitly.
@rittneje: This issue is currently awaiting triage.
If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@rittneje I agree keep-alive option must be an integer number and same thing is mentioned in https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/#keep-alive
It is also mention that even integers will be written as string in configmap
@kundan2707: Closing this issue.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.