ingress-nginx
ingress-nginx copied to clipboard
kubernetes
replace httpbin
- https://kubernetes.slack.com/archives/C021E147ZA4/p1659815361972969
- The project uses the app https://httpbin.org/ to create a workload for testing
- httpbin.org is not maintained since 4 years
- When we tried to build this project's test related images on alpine-v3.16.1 for a CVE fix, the image crashed because some code within httpbin.org did not work with alpine-v3.16.1
- This Issue is to replace httpin.org with https://httpbun.org
- httpbun.org is actively maintained and writen in go
- There seem to be many alternatives but if the api changes then test code will also need to change so more work and we don't ahve anough resources for it
- Also httpbun was inspired by httpbin so hopefully we retain current simplicity instead of adding more complexity by choosing an alternative that is not having any similarities with httpbin
/good-first-issue
@longwuyuan I would like to solve this issue:
* Why are we solving this issue?
I started to contribute to many projects in github, and would like to contribute where I can :)
* To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
replacing an older url with a new one, and then check if the api got changed
* Does this issue have zero to low barrier of entry?
yes
* How can the assignee reach out to you for help?
Click on my profile ;)
- @MalikMlitat Please assign to yourself and go ahead.
make kind-e2e-testmust work after this change.
- @MalikMlitat Please assign to yourself and go ahead.
no self assignment is possible
* `make kind-e2e-test` must work after this change.
sue
- What is the ETA for completing this @MalikMlitat
it depends, if its only the url, this can be done today, but if there are more changes excepted due to api change maybe until end of this week
that image does not show you posting /assign and the resulting message from bot. I don't even see your post "/assign" . Try to post just this and noting else /assign
Hey, if this is an issue that is not being worked on, I'll be able to work on this.
You can fork the project, make the changes and run make kind-e2e-test to see the results. Then update here. I plan to do the same.
@MalikMlitat @Aryan-Deshpande , my preference is not to wait on this. I will also try the changes locally. If it works for me, then I will try to submit PR unless one of you beat me to it. Thanks
You can fork the project, make the changes and run
make kind-e2e-testto see the results. Then update here. I plan to do the same.
👍🏻
@longwuyuan Created the change and ran "make kind-e2e-test"
Looks like the tests were passed. Can I create a PR?
@MalikMlitat & @Aryan-Deshpande when will you complete this ?
We should be able to resolve this within the next 48 hours. I have successfully been able to build httpbun from scratch, working on multi-stage building in the dockerfile.
We should be able to resolve this within the next 48 hours. I have successfully been able to build httpbun from scratch, working on multi-stage building in the dockerfile.
Thanks for update
/remove good-first-issue Because multiple experienced folks are working on it and getting blocked for lack of clarifications
/remove-help-wanted Because multiple experienced folks are working on it and getting blocked for lack of clarifications
assign to yourself and ask questions on kubernetes slack in the ingress-nginx-dev channel
hey @longwuyuan I am currently working on the PR, would like to work with @Mahadsid side by side if he would like to as well. I think we can get this issue closed if we'd work together. Although I need to conduct a few tests ( going to reform ingress-nginx with the new Docker image for httpbun ) and implement changes to this PR, and can hopefully get this PR merged soon.