ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

fix(controller): typo in catch-all CheckIngress error message

Open aslafy-z opened this issue 3 years ago • 3 comments

What this PR does / why we need it:

Fixes a typo (spec.defaultBackend instead of spec.backend).

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

This was not tested.

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I've read the CONTRIBUTION guide
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

aslafy-z avatar Aug 04 '22 11:08 aslafy-z

Hi @aslafy-z. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 04 '22 11:08 k8s-ci-robot

/ok-to-test /priority backlog /triage accepted /kind bug

strongjz avatar Aug 06 '22 18:08 strongjz

/lgtm /approve Thanks

rikatz avatar Aug 22 '22 23:08 rikatz

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aslafy-z, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 22 '22 23:08 k8s-ci-robot