ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

Added Helm Version To The Support Versions table

Open Aryan-Deshpande opened this issue 3 years ago • 5 comments

What this PR does / why we need it:

Fixes an issue, by adding the helm version to the Support Versions table. Alongside also changed the way kubernetes version is displayed to make it more readable along with the helm version supported.

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] Documentation only

Which issue/s this PR fixes

Add helm version column to support table in readme #7961

How Has This Been Tested?

Only previewed the documentation

Checklist:

  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I've read the CONTRIBUTION guide
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

Aryan-Deshpande avatar Jul 27 '22 18:07 Aryan-Deshpande

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Aryan-Deshpande / name: Aryan Deshpande (27f23ed89605a3b22a93fca19728481ac0c871dc, 5953e578d22ce54d1a35881ef506b085b6fa9ce6)

@Aryan-Deshpande: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 27 '22 18:07 k8s-ci-robot

Welcome @Aryan-Deshpande!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jul 27 '22 18:07 k8s-ci-robot

Hi @Aryan-Deshpande. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 27 '22 18:07 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aryan-Deshpande Once this PR has been reviewed and has the lgtm label, please assign rikatz for approval by writing /assign @rikatz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 27 '22 18:07 k8s-ci-robot

I've tried a few different versions side by side, and there doesn't seem to be a problem. However, it makes sense to install the corresponding versions of helm and controller based on the k8s version since they are dependent on the Kubernetes version.

Aryan-Deshpande avatar Aug 11 '22 13:08 Aryan-Deshpande