ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

Document internal-logger-address cli arg

Open nissessenap opened this issue 3 years ago • 5 comments

Signed-off-by: Edvin Norling [email protected]

What this PR does / why we need it:

Visualize the internal-logger-address config flag in the documentation. This flag only used during usage of the chroot image.

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [X] Documentation only

Which issue/s this PR fixes

fixes #8839

How Has This Been Tested?

N/A

Checklist:

  • [X] My change requires a change to the documentation.
  • [X] I have updated the documentation accordingly.
  • [X] I've read the CONTRIBUTION guide
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

nissessenap avatar Jul 27 '22 09:07 nissessenap

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: NissesSenap / name: Edvin N (5677e2e749c2aeff286d4bc508bf12e57543508d)

@NissesSenap: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 27 '22 09:07 k8s-ci-robot

Welcome @NissesSenap!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jul 27 '22 09:07 k8s-ci-robot

Hi @NissesSenap. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 27 '22 09:07 k8s-ci-robot

oops my bad :) Thanks!!

/lgtm /approve

rikatz avatar Aug 22 '22 23:08 rikatz

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NissesSenap, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 22 '22 23:08 k8s-ci-robot