ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

Deprecate Jaeger and Opentracing in favor of OpenTelemetry

Open rikatz opened this issue 2 years ago • 14 comments

OTEL is around for a while. We even have a starting implementation in NGINX.

In an effort to simplify our code, the compilation times, etc we need to remove the features Jaeger and Opentracing and keep only opentelemetry.

To not break users, maybe we need to analyze when an old jaeger directive was used and configure otel to send proper traces. We need to check;

  • Is OTEL compatible with Jaeger? Can we just migrate the configs of Jaeger to OTEL (in NGINX tempalte?)
  • Is OTEL compatible with OpenTracing? Same as above?

This is just a boilerplate issue, but we need to evolve it

/triage accepted /kind cleanup /priority important-longterm

rikatz avatar Jun 12 '22 21:06 rikatz

https://www.jaegertracing.io/docs/1.35/client-libraries/ <- Reference on the Jaeger clients being deprecated

rikatz avatar Jun 12 '22 21:06 rikatz

Probably we also need to know how many people are currently using this feature.

tao12345666333 avatar Jun 15 '22 09:06 tao12345666333

Jaeger cli is deprecated so we can move this.

rikatz avatar Jun 15 '22 12:06 rikatz

jaeger-client-cpp is no longer fixing bugs https://github.com/jaegertracing/jaeger-client-cpp/issues/292, so OpenTelemetry support has become more important

andremarianiello avatar Aug 31 '22 14:08 andremarianiello

What is blocking this, exactly?

andremarianiello avatar Aug 31 '22 14:08 andremarianiello

No blocker per se, but there is stabilization work in progress so lack of developer time. As soon as the higher priority stabiilization work is under control, some developer time will go into opentelemetry.

longwuyuan avatar Aug 31 '22 14:08 longwuyuan

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 29 '22 15:11 k8s-triage-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 29 '22 16:11 k8s-triage-robot

/remove-lifecycle stale

andremarianiello avatar Nov 29 '22 16:11 andremarianiello

/assign

esigo avatar Nov 29 '22 16:11 esigo

We should keep an eye also on https://github.com/kubernetes/ingress-nginx/issues/10082

rikatz avatar Jun 29 '23 11:06 rikatz

I think for #10082 we have reached an agreement. https://github.com/kubernetes/ingress-nginx/issues/10082#issuecomment-1613753574

And I saw there has a PR #10151 works and relegated with this one.

tao12345666333 avatar Jun 30 '23 12:06 tao12345666333

/assign

longwuyuan avatar May 01 '24 17:05 longwuyuan

We have to support opentracing for controller v1.9 builds so this PR https://github.com/kubernetes/ingress-nginx/pull/10913 needs to be cleaned up and merged after releasing controller v1.11

longwuyuan avatar May 03 '24 01:05 longwuyuan