ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

Stale Documentation: Website/README claims that wildcard hosts are not supported

Open zawachte-c opened this issue 3 years ago • 6 comments

What happened:

https://github.com/kubernetes/ingress-nginx/blob/main/docs/user-guide/ingress-path-matching.md and on the website it says

Regular expressions and wild cards are not supported in the spec.rules.host field. Full hostnames must be used.

What you expected to happen:

This is not true anymore, right? I am pretty sure that wildcard hosts are now supported.

zawachte-c avatar Apr 27 '22 19:04 zawachte-c

@zawachte-c: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 27 '22 19:04 k8s-ci-robot

/remove-kind bug /kind docs

The context is that that a wildcard character, all by itself with no suffix, is not supported as documented here https://kubernetes.io/docs/concepts/services-networking/ingress/#hostname-wildcards and kubectl explain ingress.spec.rules.host

longwuyuan avatar Apr 28 '22 00:04 longwuyuan

@longwuyuan: The label(s) kind/docs cannot be applied, because the repository doesn't have them.

In response to this:

/remove-kind bug /kind docs

The context is that that a wildcard character, all by itself with no suffix, is not supported as documented here https://kubernetes.io/docs/concepts/services-networking/ingress/#hostname-wildcards and kubectl explain ingress.spec.rules.host

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 28 '22 00:04 k8s-ci-robot

/kind documentation

kundan2707 avatar Apr 28 '22 08:04 kundan2707

Oh I just thought it was leftover from before when kubernetes didn't support wildcard hosts upstream. ( k8s < 1.18)

https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/#support-for-hostname-wildcards

zawachte-c avatar Apr 28 '22 12:04 zawachte-c

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 27 '22 13:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 26 '22 13:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Sep 25 '22 13:09 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 25 '22 13:09 k8s-ci-robot