ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

Add update updateStrategy and minReadySeconds for defaultBackend

Open yutachaos opened this issue 2 years ago • 12 comments

What this PR does / why we need it:

  • I want using update strategy for deafult backend deployment.

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation only

Which issue/s this PR fixes

  • https://github.com/kubernetes/ingress-nginx/issues/8514

How Has This Been Tested?

Checklist:

  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I've read the CONTRIBUTION guide
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

yutachaos avatar Apr 25 '22 08:04 yutachaos

@yutachaos: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 25 '22 08:04 k8s-ci-robot

Welcome @yutachaos!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Apr 25 '22 08:04 k8s-ci-robot

Hi @yutachaos. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 25 '22 08:04 k8s-ci-robot

@yutachaos: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 25 '22 09:04 k8s-ci-robot

@yutachaos it may help if you add some context to this PR. For example you could create a issue that describes what problem is solved by this PR. And link the issue here. Or you can just add description here, by editing the first post, and explain what problem you faced and how this PR solves that problem.

longwuyuan avatar Apr 26 '22 00:04 longwuyuan

@yutachaos it may help if you add some context to this PR. For example you could create a issue that describes what problem is solved by this PR. And link the issue here. Or you can just add description here, by editing the first post, and explain what problem you faced and how this PR solves that problem.

Thank you for you comment. Added issue number.

yutachaos avatar Apr 26 '22 03:04 yutachaos

Thanks for the update. Can you copy paste the results you are getting. Like the curl command in loop with -v.

Thanks, ; Long

On Tue, 26 Apr, 2022, 8:39 AM yutachaos, @.***> wrote:

@yutachaos https://github.com/yutachaos it may help if you add some context to this PR. For example you could create a issue that describes what problem is solved by this PR. And link the issue here. Or you can just add description here, by editing the first post, and explain what problem you faced and how this PR solves that problem.

Thank you for you comment. Added issue number.

— Reply to this email directly, view it on GitHub https://github.com/kubernetes/ingress-nginx/pull/8506#issuecomment-1109253855, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGZVWVYEVGAZJI2RB5ZURTVG5M4VANCNFSM5UHYSENA . You are receiving this because you commented.Message ID: @.***>

longwuyuan avatar Apr 26 '22 03:04 longwuyuan

@cpanato Thanks. I bumped chart version.

yutachaos avatar Apr 29 '22 08:04 yutachaos

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 22 '22 13:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 21 '22 13:09 k8s-triage-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yutachaos Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval by writing /assign @cpanato in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 25 '22 09:09 k8s-ci-robot

@cpanato @longwuyuan I would appreciate it if someone could review it 🙏

yutachaos avatar Sep 25 '22 09:09 yutachaos

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Nov 08 '22 16:11 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 08 '22 16:11 k8s-ci-robot

/reopen

yutachaos avatar Dec 27 '22 15:12 yutachaos

@yutachaos: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 27 '22 15:12 k8s-ci-robot

/lgtm /approve Sorry for taking so long, I missed this on my queue! Thanks!

rikatz avatar Jan 08 '23 22:01 rikatz

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, yutachaos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jan 08 '23 22:01 k8s-ci-robot