ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

fix: continue updating backends during shutdown

Open grounded042 opened this issue 7 months ago • 6 comments

What this PR does / why we need it:

Draft PR for fixing #13215. Will fill out more soon.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] CVE Report (Scanner found CVE and adding report)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation only

Which issue/s this PR fixes

fixes #13215

How Has This Been Tested?

I've tested it manually via make dev-env and following re-production steps in #13215

Checklist:

TODO

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I've read the CONTRIBUTION guide
  • [ ] I have added unit and/or e2e tests to cover my changes.
  • [ ] All new and existing tests passed.

grounded042 avatar Apr 14 '25 22:04 grounded042

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: grounded042 Once this PR has been reviewed and has the lgtm label, please assign gacko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 14 '25 22:04 k8s-ci-robot

Hi @grounded042. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Apr 14 '25 22:04 k8s-ci-robot

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
Latest commit 0ca05be79f0156bd16a0ccf9ae3188039ded11c3
Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/67fd88cc441bee000821ffbf

netlify[bot] avatar Apr 14 '25 22:04 netlify[bot]

Talked with @grounded042 during sync. he is going to add a go unit test and then we can review for 1.13 release.

strongjz avatar May 08 '25 15:05 strongjz

/triage accepted /ok-to-test /priority backlog /kind feature

strongjz avatar May 08 '25 15:05 strongjz