ingress-nginx
ingress-nginx copied to clipboard
Admission webhooks vol add
What this PR does / why we need it:
This change helps add extraVolumes and extraVolumeMounts for the AdmissionsWebhooks Job-Patch createSecret and patchwebhook Jobs. Currently if automountServiceAccountToken is set to false in both the jobs, the jobs will fail. That was our initial issue. By merging the current PR, it provides an approach to manually add extraVolumes and extraVolumeMounts so that the jobs run smoothly.
This PR helps resolve Issue: https://github.com/kubernetes/ingress-nginx/issues/13031.
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] CVE Report (Scanner found CVE and adding report)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Documentation only
Which issue/s this PR fixes
How Has This Been Tested?
We had tested this in our local and dev Kubernetes clusters. We manually downloaded the latest HELM charts and applied these changes and tested.
We had tested this in our local and dev K8s cluster environments.
Currently if automountServiceAccountToken is set to false in both the jobs, the jobs will fail. That was our initial issue. By merging the current PR, it provides an approach to manually add extraVolumes and extraVolumeMounts so that the jobs run smoothly.
Checklist:
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I've read the CONTRIBUTION guide
- [x] I have added unit and/or e2e tests to cover my changes.
- [ ] All new and existing tests passed.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: arjunbnair97 (0942cce87697a16de5e900828b605d4b4b014a61, a68eacbfd60e79d0aec12b28d885a1c911c93a1a, 65918a325a039d2b23c12d040de88a9bf7fa9b95, d140560c80d550afb35c9df626a4d3d95250fcae, 36c7e0a9c255b287fd339ce2cec4b6a07654c053, 27547a4a372b8dfb6ee9dd53045b58cb51ef64b7, cda5f8ef45afd06d83de4d3a9c000d51440dae13, 1f8d3574ac573a720eff27c0ac8b40e8f5d7e8db, 98b9f5d45fa3d19a36139b958a2ba55714ccd28c, ff273ebc5cc561839d0094c5b958d57d01875b45, f8e321ef4a03a3b88b23092fafa274f72ae3c2a6, 90c3e6d9eacb68fa9f94cd8fd23d4a63b1d73155, 2ca8e08967043765228c08e3b05c5bc1cbedf5e2, 2c28c5711b460fd24ca504d1808098e1ae40eeeb, 573e885cd906602f0b84b9b1a7075cd9622443c7, eb23e9060a381a950f8557f7991c75701fcc562f, 32b51b137fe20f09ff63547871062c57f36e5ad5, ff79a01339b67c061ed54c93604d4cc14ba7a676)
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: arjunbnair97 Once this PR has been reviewed and has the lgtm label, please assign strongjz for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @arjunbnair97!
It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/ingress-nginx has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @arjunbnair97. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-ingress-nginx canceled.
| Name | Link |
|---|---|
| Latest commit | 573e885cd906602f0b84b9b1a7075cd9622443c7 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/67ebd3e4f9c50f000835a080 |
@Gacko Could you please review?
Your changes are currently breaking tests. Please see the details of the failed checks for why.