ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

Switch default OTel sampler to TraceIdRatioBased

Open GFriedrich opened this issue 10 months ago • 12 comments

What this PR does / why we need it:

  • switches the default OTel sampler from AlwaysOn to TraceIdRatioBased, which is a more sane default in regards to load
    • solves #12443
  • fixes various documentation inconsitencies
    • solves #12443 and #12432

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] CVE Report (Scanner found CVE and adding report)
  • [x] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] Documentation

Which issue/s this PR fixes

fixes #12443 fixes #12432

How Has This Been Tested?

Checked that the default generated config files contains the expected configuration.

Checklist:

  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I've read the CONTRIBUTION guide
  • [ ] I have added unit and/or e2e tests to cover my changes.
  • [x] All new and existing tests passed.

GFriedrich avatar Dec 08 '24 18:12 GFriedrich