ingress-nginx
ingress-nginx copied to clipboard
Fix make clean
Avoid elevating permissions to clean cache directories by using host user in docker and -modcacherw in go build command.
Permissions were used previously but were modified in #8400 to be used for mac users only and subsequently removed in #9124.
The issue let me think that no one runs make clean, so another option is just to remove it.
What this PR does / why we need it:
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] CVE Report (Scanner found CVE and adding report)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Documentation only
Which issue/s this PR fixes
fixes #12227
How Has This Been Tested?
Checklist:
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I've read the CONTRIBUTION guide
- [ ] I have added unit and/or e2e tests to cover my changes.
- [ ] All new and existing tests passed.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mneverov Once this PR has been reviewed and has the lgtm label, please assign gacko for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
This issue is currently awaiting triage.
If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-ingress-nginx canceled.
| Name | Link |
|---|---|
| Latest commit | 7a8315f146c713575fcc26c70bc17a407bb9a804 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/67190369e898680008e5627a |
I think local dev/test requires make clean
If this is about Go cache files, the issue is not about the user, but about the file permissions. And there is a reason for them to be read-only I'd like to keep that.
If this is about Go cache files, the issue is not about the user, but about the file permissions.
@Gacko can you post the ls -lart output from the repo root folder and ls -lart rootfs?
And there is a reason for them to be read-only I'd like to keep that.
Can you clarify what the reason is?
As I mentioned, I cloned the repo, ran make build; make clean and the latter failed. If it works as intended, why not removing the target at all?
This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.
The lifecycle/frozen label can not be applied to PRs.
This bot removes lifecycle/frozen from PRs because:
- Commenting
/lifecycle frozenon a PR has not worked since March 2021 - PRs that remain open for >150 days are unlikely to be easily rebased
You can:
- Rebase this PR and attempt to get it merged
- Close this PR with
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/remove-lifecycle frozen