ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

NGINX: Remove inline Lua from template.

Open rikatz opened this issue 1 year ago • 14 comments

What this PR does / why we need it:

We need to simplify our lifes and the nginx.conf file. This PR is the beginning of the work to remove any lua inline script from nginx template, calling the lua script directly.

The end goal is to remove any by_lua_block directive, even if this means we add more lua scripts temporarily

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] CVE Report (Scanner found CVE and adding report)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I've read the CONTRIBUTION guide
  • [ ] I have added unit and/or e2e tests to cover my changes.
  • [ ] All new and existing tests passed.

rikatz avatar Aug 14 '24 22:08 rikatz

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 14 '24 22:08 k8s-ci-robot

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
Latest commit aa5c3ec0109402eb83f033e5f9d5f673f1fb8def
Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66ddc92ab3da2600082f6aba

netlify[bot] avatar Aug 14 '24 22:08 netlify[bot]

Do you want to merge this to main or the NGINX crossplane branch?

Gacko avatar Aug 15 '24 06:08 Gacko

@Gacko to main :)

rikatz avatar Aug 15 '24 13:08 rikatz

Then please wait until after the release. 😅

Gacko avatar Aug 15 '24 13:08 Gacko

Then please wait until after the release. 😅

I'm not on a rush :P

rikatz avatar Aug 15 '24 14:08 rikatz

/lgtm

Gacko avatar Aug 16 '24 07:08 Gacko

/unhold

Gacko avatar Aug 16 '24 07:08 Gacko

@rikatz I rebased your branch. Unhold whenever ready. :)

Gacko avatar Aug 16 '24 07:08 Gacko

/hold

I will still finish the other migrations! :D Will let you know once it is ready

rikatz avatar Aug 16 '24 13:08 rikatz

/assign @tao12345666333

rikatz avatar Aug 18 '24 18:08 rikatz

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, rikatz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [Gacko,rikatz,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 01 '24 08:09 k8s-ci-robot

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Sep 08 '24 15:09 k8s-ci-robot

@rikatz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ingress-nginx-lualint b65dae6b80609c53e1255ffafec0d86032a601a4 link true /test pull-ingress-nginx-lualint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Sep 08 '24 15:09 k8s-ci-robot

/hold cancel

rikatz avatar Sep 08 '24 21:09 rikatz