ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

The validation webhook for proxy-related Annotations does not return errors.

Open zengyuxing007 opened this issue 6 months ago • 3 comments

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    nginx.ingress.kubernetes.io/proxy-read-timeout: "120s"
  name: my-ip-ingress
  namespace: default
spec:
  ingressClassName: nginx
  rules:
  - host: www.example.com
    http:
      paths:
      - backend:
          service:
            name: httpbin
            port:
              number: 8000
        path: /
        pathType: Prefix

Some Nginx users often misconfigure the related timeout settings, but the webhook doesn't provide any error feedback, which is incorrect.

the coorect annotation should be:

    nginx.ingress.kubernetes.io/proxy-read-timeout: "120"

The fix should be straightforward; just modify the parsing logic in internal/ingress/annotations/proxy/main.go. I hope someone can fix this issue. Thank you.

zengyuxing007 avatar Aug 05 '24 08:08 zengyuxing007