ingress-nginx
ingress-nginx copied to clipboard
kubernetes
Bump otel_ngx_module
What this PR does / why we need it:
This PR bump the oTel module to 415f1824df55d8c35793c72af68742d7f999b3e2. There's two notable commits between the previous commit and this one:
- https://github.com/open-telemetry/opentelemetry-cpp-contrib/pull/451
- https://github.com/open-telemetry/opentelemetry-cpp-contrib/pull/443
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] CVE Report (Scanner found CVE and adding report)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Documentation only
Which issue/s this PR fixes
How Has This Been Tested?
Yes, manually.
Checklist:
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I've read the CONTRIBUTION guide
- [ ] I have added unit and/or e2e tests to cover my changes.
- [ ] All new and existing tests passed.
Welcome @dmehala!
It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/ingress-nginx has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @dmehala. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-ingress-nginx canceled.
| Name | Link |
|---|---|
| Latest commit | d08027b3c12ee9674741b5c2e9ba9c2f057bbaa4 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66dd4f77a3517d00084fb1a2 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@dmehala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Hey,
I just got some time to have a deeper look into your change.
I can totally understand that you'd like to have this particular commit in use in Ingress NGINX, because its your contribution and you made it for a reason.
Unfortunately we'd rather go for a real release than a commit on their main branch, even if this has not been the case in the past. I'd therefore try to implement their v1.1.0 release and also bump NGINX support to v1.25.5.
Of course this would not include your changes, but at least be a official release and align NGINX versions.
We've been burned in the on different components and using commits, not releases.
Hey @Gacko @strongjz ,
I completely understand, and that’s totally fair. I am wondering if you’re planning to integrate the new otel module (otel-webserver)?
Either way, I'm happy to help if you'd like :)
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dmehala, esigo, Gacko
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Gacko]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.
In response to this:
/cherry-pick release-1.10
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.
In response to this:
/cherry-pick release-1.11
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@Gacko: new pull request created: #11950
In response to this:
/cherry-pick release-1.10
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@Gacko: new pull request created: #11951
In response to this:
/cherry-pick release-1.11
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
I understand the intention to use only tagged releases, but I'm wondering if it makes sense at the moment, since there doesn't seem to be a release process for the opentelemetry-cpp-contrib/instrumentation/nginx module at all.
The releases visible for opentelemetry-cpp-contrib seem to be only for the instrumentation/otel-webserver-module library, which isn't used here as far as I can tell.
