ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

Update ingress-path-matching.md

Open zengyuxing007 opened this issue 1 year ago • 4 comments

What this PR does / why we need it:

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] CVE Report (Scanner found CVE and adding report)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I've read the CONTRIBUTION guide
  • [ ] I have added unit and/or e2e tests to cover my changes.
  • [ ] All new and existing tests passed.

zengyuxing007 avatar Feb 22 '24 03:02 zengyuxing007

Hi @zengyuxing007. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 22 '24 03:02 k8s-ci-robot

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
Latest commit 98ec172c76039fe92e4af11619fbdcfe3da4a41a
Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65d6e35759180700096a566f

netlify[bot] avatar Feb 22 '24 03:02 netlify[bot]

@zengyuxing007 thanks for the contribution

  • Please check the preview URL https://deploy-preview-11008--kubernetes-ingress-nginx.netlify.app/user-guide/ingress-path-matching/ . The asterisk is not visible

longwuyuan avatar Feb 22 '24 05:02 longwuyuan

@zengyuxing007 tip

  • You need to escape the asterisk with a backslash "\" like this example below

image

longwuyuan avatar Feb 22 '24 05:02 longwuyuan

escape the asterisk character with a backslash, to render in markdown

thanks, it is fixed ~

zengyuxing007 avatar Feb 22 '24 05:02 zengyuxing007

Please squash your commits

longwuyuan avatar Feb 22 '24 05:02 longwuyuan

https://www.git-tower.com/learn/git/faq/git-squash/

longwuyuan avatar Feb 22 '24 06:02 longwuyuan

https://www.git-tower.com/learn/git/faq/git-squash/

done

zengyuxing007 avatar Feb 22 '24 06:02 zengyuxing007

/ok-to-test /lgtm /approve

longwuyuan avatar Feb 22 '24 06:02 longwuyuan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, zengyuxing007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 22 '24 06:02 k8s-ci-robot

/kind documentation /triage accepted

longwuyuan avatar Feb 22 '24 06:02 longwuyuan