ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

Chotiwat/ssl passthrough e2e

Open chotiwat opened this issue 1 year ago • 7 comments

e2e tests from #10454 without the actual fix. These should break.

What this PR does / why we need it:

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] CVE Report (Scanner found CVE and adding report)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I've read the CONTRIBUTION guide
  • [ ] I have added unit and/or e2e tests to cover my changes.
  • [ ] All new and existing tests passed.

chotiwat avatar Feb 16 '24 10:02 chotiwat

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chotiwat Once this PR has been reviewed and has the lgtm label, please assign strongjz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 16 '24 10:02 k8s-ci-robot

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 16 '24 10:02 k8s-ci-robot

Hi @chotiwat. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 16 '24 10:02 k8s-ci-robot

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
Latest commit 052643e1cf333cea72bb5405642c234642ca335d
Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65cff173c7b9c200089d070a

netlify[bot] avatar Feb 16 '24 10:02 netlify[bot]

Add the tests here

longwuyuan avatar Feb 16 '24 12:02 longwuyuan

Add the tests here

Sorry, what do you mean?

chotiwat avatar Feb 16 '24 23:02 chotiwat

Add the tests here

Sorry, what do you mean?

  • I meant for the change and the tests to be in the same PR. Sorry i was not clear on that.
  • Can you please squash your commits
  • I am not a developer but I am extremely skeptical of the approach and assumptions here. If I can't reproduce the half-read connection using a stress tool like "hey" or "httperf" or "locust" or other such, then my opinion is that the changes you propose should not be forced on all the other users (simply because nonbody else is reporting this and we can not reproduce at will, so why fix things that are not broken)
  • Maybe you use case and your app have relative uniqueness for the incomplete read situation. Maybe your infra and networking contribute to the problem. If not then I should be able to reproduce at will with kin/minikube on any infra anywhere

longwuyuan avatar Feb 17 '24 00:02 longwuyuan

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 08 '24 00:03 k8s-ci-robot