ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

[release-1.9] Chart: Set `--enable-metrics` depending on `controller.metrics.enabled`.

Open k8s-infra-cherrypick-robot opened this issue 1 year ago • 9 comments

This is an automated cherry-pick of #10959

/assign Gacko

/lgtm

Gacko avatar Feb 02 '24 08:02 Gacko

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gacko, k8s-infra-cherrypick-robot Once this PR has been reviewed and has the lgtm label, please assign strongjz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 02 '24 08:02 k8s-ci-robot

/kind bug /priority backlog /triage accepted /assign

Gacko avatar Feb 02 '24 09:02 Gacko

/label needs-rebase

Gacko avatar Feb 02 '24 09:02 Gacko

@Gacko: The label(s) /label needs-rebase cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label needs-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 02 '24 09:02 k8s-ci-robot

/retest

Gacko avatar Feb 02 '24 10:02 Gacko

/ok-to-test

Gacko avatar Feb 02 '24 11:02 Gacko

/retest

Gacko avatar Feb 02 '24 11:02 Gacko

/rebase

strongjz avatar Feb 02 '24 14:02 strongjz

/close

Gacko avatar Feb 28 '24 11:02 Gacko

@Gacko: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 28 '24 11:02 k8s-ci-robot