ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

Add standard Forwarded header support

Open zitudu opened this issue 2 years ago • 8 comments

What this PR does / why we need it:

Add support of standard Forwarded defined by RFC 7239. Implement #10263

ConfigMap options:

	// Enable standard forwarded header.
	// Default: false
	EnableForwardedRFC7239 bool `json:"enable-forwarded-rfc7239"`

	// Sets if strips incoming Forwarded header.
	// Default: false
	ForwardedRFC7239StripIncomming bool `json:"forwarded-rfc7239-strip-incomming"`

	// Sets Forwarded parameters and their order. Available options are "for", "by", "host", "proto".
	// Default: "for"
	ForwardedRFC7239 []string `json:"forwarded-rfc7239"`

	// Sets Forwarded "for" parameter node identifier, should be "ip" or a static obfuscated string.
	// Default: "ip"
	ForwardedRFC7239For string `json:"forwarded-rfc7239-for,omitempty"`

	// Sets Forwarded "by" parameter node identifier, should be "ip" or a static obfuscated string.
	// Default: "ip"
	ForwardedRFC7239By string `json:"forwarded-rfc7239-by,omitempty"`

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] CVE Report (Scanner found CVE and adding report)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I've read the CONTRIBUTION guide
  • [x] I have added unit and/or e2e tests to cover my changes.
  • [x] All new and existing tests passed.

zitudu avatar Aug 16 '23 06:08 zitudu

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
Latest commit cee878be25363f83972b7451ea99734b903e4a89
Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/64ddd0c8e154b50009d65aaf

netlify[bot] avatar Aug 16 '23 06:08 netlify[bot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 16 '23 06:08 k8s-ci-robot

Welcome @zitudu!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 16 '23 06:08 k8s-ci-robot

Hi @zitudu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 16 '23 06:08 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zitudu Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 16 '23 06:08 k8s-ci-robot

hi, @strongjz @cpanato @puerco. It is ready for review. I'm looking forward to your suggestions to make this implementation better。

zitudu avatar Aug 25 '23 06:08 zitudu

/assign

rikatz avatar Sep 12 '23 15:09 rikatz

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 25 '24 10:03 k8s-ci-robot