ingress-gce icon indicating copy to clipboard operation
ingress-gce copied to clipboard

Add Hostname to HealthCheckConfig

Open AngellusMortis opened this issue 2 years ago • 6 comments

Reopen https://github.com/kubernetes/ingress-gce/issues/1046

The docs say the request host header will be set if it is in the pod containers spec.

Request Host header | Host: backend-ip-address | if present in the serving Pod's spec: containers[].readinessProbe.httpGet.httpHeaders

The issue is that this creates a race condition when first creating an ingress if it is created before the pods are deployed (i.e. via Helm). This means if you are deploying an application with strict hostname checking (i.e. Django), your ingress/load balancers will never become healthly unless you delete the ingress and re-add it after the initial deploy.

So it would be nice to actually be able to configure the hostname for the healthcheck as defined in the healthchecks REST API reference

Something like:

apiVersion: cloud.google.com/v1
kind: BackendConfig
metadata:
  name: service-backend-config
spec:
  healthCheck:
    requestPath: /healthcheck/
    host: example.com

AngellusMortis avatar Aug 15 '23 14:08 AngellusMortis

I also need this. I don't always have control over what hostname deployment respond on. This is critical and I can do this in the console but not the BackendConfig. There's no technical reason why this couldn't be done.

andrewsingley-glv avatar Sep 14 '23 17:09 andrewsingley-glv

+1 for this as well.

jasonwzm avatar Sep 26 '23 23:09 jasonwzm

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 29 '24 05:01 k8s-triage-robot

/remove-lifecycle stale

AngellusMortis avatar Jan 29 '24 05:01 AngellusMortis

/kind feature /lifecycle frozen

swetharepakula avatar Mar 07 '24 00:03 swetharepakula