Add errcheck to test suite to ensure all errors produced are checked

[michaelasp]

Add the errcheck utility to check and see if there are any functions that produce an error which do not get checked after. Also fixes some issues related to this in sections, no functionality changes, we generally just log the error if it happens.

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: michaelasp (ad9255f840dd56321e862cd0be369163bd649379)

[k8s-ci-robot]

Welcome @michaelasp!

It looks like this is your first PR to kubernetes/ingress-gce 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-gce has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @michaelasp. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[michaelasp]

/check-cla

[swetharepakula]

/ok-to-test

[michaelasp]

Modified upon the idea from @panslava that we can use golang-ci instead. Won't compile until #1779 is resolved since golang-ci uses a higher go version. This should allow for more extensibility in the future and the ability to add more linters!

[michaelasp]

Works as intended with newest go version bump, @panslava @swetharepakula PTAL!

[panslava]

Thank you, great job with CI!

LGTM from me, but I want someone else to also take a look

[cezarygerard]

Hi @michaelasp

can you add 2-line README.md file to hack/tools with info

1. what the tools do
2. how they are run

thanks

[michaelasp]

Added readme and modified the go version to match the actual version.

[swetharepakula]

Thanks @michaelasp!

This is a great addition!

/lgtm /approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelasp, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [swetharepakula]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment