ingress-gce icon indicating copy to clipboard operation
ingress-gce copied to clipboard

Fix creation of NEGs in the new zone when cluster spans to the new zone

Open gauravkghildiyal opened this issue 2 years ago • 3 comments

  • Propagate node update events for both NEG types (GCE_VM_IP_PORT + GCE_VM_IP)

  • Configure separate zoneMaps for the NEG types (vmIpZoneMap and vmIpPortZoneMap). These zoneMaps will be updated using the same predicate function that is eventually used inside transactionSyncer.isZoneChange() for the respective NEG types.

  • Introduce a new function NodePredicateForNetworkEndpointType that will be the source of truth for the type of predicate function to be used for a given NEG type.

For future reference, here's another related PR: https://github.com/kubernetes/ingress-gce/pull/1600

/assign @swetharepakula

gauravkghildiyal avatar Jul 20 '22 17:07 gauravkghildiyal

Hi @gauravkghildiyal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 20 '22 17:07 k8s-ci-robot

/ok-to-test

swetharepakula avatar Jul 26 '22 22:07 swetharepakula

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 26 '22 20:08 k8s-ci-robot