kubernetes
Promote Topology Labels to GA
Enhancement Description
- One-line enhancement description (can be used as a release note):
The topology labels by cloud providers we apply on nodes have been in "beta" for a very long time. Given their usage across the project we should GA them.
The 3 labels are:
beta.kubernetes.io/instance-type
failure-domain.beta.kubernetes.io/zone
failure-domain.beta.kubernetes.io/region
They should be renamed to:
node.kubernetes.io/instance-type
topology.kubernetes.io/zone
topology.kubernetes.io/region
While keeping backwards compatibility in mind. Changing the label format may also be an option given we have to rename the label key anyways.
-
Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cloud-provider/20190215-promoting-cloud-provider-labels.md
-
Primary contact (assignee): @andrewsykim
-
Responsible SIGs: SIG Cloud Provider, SIG Node
-
Enhancement target (which target equals to which milestone):
- Stable release target (v1.15)
/kind api-change
related discussion in https://github.com/kubernetes/kubernetes/pull/73616#discussion_r253227406
cc @liggitt @thockin @dims
@MorrisLaw has volunteered to implement this once the KEP PR is merged, thank you!
Hi @andrewsykim. I'm the 1.15 Enhancement Lead. Has the KEP for this been approved? If so, can we update the original post to reflect it? We will get this tracked for 1.15. If there are any open k/k PRs, please drop them into this issue so they can be properly tracked during code freeze. Thanks!
/stage stable
@kacole2 KEP is still being reviewed here https://github.com/kubernetes/enhancements/pull/839. Once the PR is approved I'll update the issue, thanks!
@andrewsykim Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.
@andrewsykim Enhancement Freeze for Kubernetes 1.15 has passed and this did not meet the deadline. This is now being removed from the 1.15 milestone and the tracking sheet. If there is a need for this to be in 1.15, please file an Enhancement Exception. Thank you.
Hi @andrewsykim , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.
Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.
Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.
Thank you.
Andrew - is this implemented somewhere just waiting for review? Or is it stalled?
Implemented here https://github.com/kubernetes/kubernetes/pull/81431 but PR slipped my radar in the last week. Will brush it up some time today and assign it to you :)
Hey there @andrewsykim @thockin -- 1.17 Enhancements shadow here 👋 . I wanted to check in and see if you think this Enhancement will be landing in 1.17?
The current release schedule is:
- Monday, September 23 - Release Cycle Begins
- Tuesday, October 15, EOD PST - Enhancements Freeze
- Thursday, November 14, EOD PST - Code Freeze
- Tuesday, November 19 - Docs must be completed and reviewed
- Monday, December 9 - Kubernetes 1.17.0 Released
If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍
We'll also need to update the KEP. To be accepted in the release, all enhancements MUST have a KEP, the KEP MUST be merged, in an implementable state, and have both graduation criteria/test plan.
Thanks!
Hey @andrewsykim, wanted to check in and see if you're still planning on having this done for the enhancements freeze? The KEP looks like it's still in provisional status, it will need to get bumped to implementable before the enhancements freeze tomorrow, EOD PT.
Sorry for the late reply, this KEP should be in implementable - https://github.com/kubernetes/enhancements/pull/1310
Hello @andrewsykim , I'm one of the v1.17 docs shadows. Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so).
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!
Hello @andrewsykim. I see the docs for this enhancement is set to "Unknown" in the Enhancement Tracker sheet. Do we need to do any work to determine if this requires a placeholder docs PR?
As a reminder, we're hoping to have placeholder PRs against kubernetes/website (branch dev-1.17) by Friday, Nov 8th. Thanks,
Hey @andrewsykim,
Jeremy from the 1.17 enhancements team here 👋 We're closing in on code freeze on Nov 14th, so I wanted to check in and see how this is going and if you think it will still GA in 1.17. It looks like implementation PR is still open kubernetes/kubernetes#81431 so wanted to check in!
Thanks in advance!
Hey @andrewsykim, reminder that we'll need a docs PR placeholder for this by the end of today. If there isn't a draft docs PR, we'll need to remove it from the 1.17 release you'll need to obtain an exception. Thanks!
Just added docs PR https://github.com/kubernetes/website/pull/17496, sorry for the delay!
Hey there sig-cloud-provider! Congrats on getting this graduated in 1.17. Could you update the KEP to mark it as implemented? Then we can go ahead and close the issue out and not leave anything in a bad state.
Spoke with @jeremyrickard on Slack, we should keep this as-is because we still have to deprecate the old labels in future releases.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
/milestone clear
(removing this issue from v1.17 milestone as the milestone is complete)
@andrewsykim What's the status of this? Is all that is left to remove the beta labels after the deprecation period?
@andrewsykim What's the status of this? Is all that is left to remove the beta labels after the deprecation period?
Yes! The current plan is to remove the beta labels for v1.21.
Thanks Andrew. We won't track in 1.19, then but defer to 1.21.
/milestone v1.21