enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

CSI Inline Volume Support

Open saad-ali opened this issue 7 years ago • 103 comments
trafficstars

Feature Description

  • One-line feature description (can be used as a release note): CSI volumes can only be referenced via PV/PVC today. This works well for remote persistent volumes. However, we would like CSI to be used to create local ephemeral volumes (e.g. volumes to inject identity information in to a pod), and these types of volumes should be able to be referred to directly in pod spec (without PV/PVC).
  • Primary contact (assignee): @dobsonj
  • Responsible SIGs: @kubernetes/sig-storage-feature-requests
  • Design proposal link (community repo): https://github.com/kubernetes/community/pull/2273
  • KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/596-csi-inline-volumes
  • Link to e2e and/or unit tests: See https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/596-csi-inline-volumes/README.md#test-plan
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @msau42
  • Approver (likely from SIG/area to which feature belongs): @saad-ali
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): 1.13
    • Beta release target (x.y): 1.16
    • Stable release target (x.y): 1.25
  • PRs
    • https://github.com/kubernetes/enhancements/pull/716
    • https://github.com/kubernetes/enhancements/pull/790
    • https://github.com/kubernetes/enhancements/pull/1172
    • https://github.com/kubernetes/enhancements/pull/3158
    • https://github.com/kubernetes/enhancements/pull/3368
    • https://github.com/kubernetes/enhancements/pull/3445
    • https://github.com/kubernetes/kubernetes/pull/74086
    • https://github.com/kubernetes/kubernetes/pull/81960
    • https://github.com/kubernetes/kubernetes/pull/82004
    • https://github.com/kubernetes/kubernetes/pull/111258
    • https://github.com/kubernetes/website/pull/10934
    • https://github.com/kubernetes/website/pull/14704
    • https://github.com/kubernetes/website/pull/15705
    • https://github.com/kubernetes/website/pull/32667
    • https://github.com/kubernetes/website/pull/35510
    • https://github.com/kubernetes/website/pull/35511
    • https://github.com/kubernetes-csi/docs/pull/508
    • https://github.com/kubernetes-csi/docs/pull/520

saad-ali avatar Jul 28 '18 00:07 saad-ali

Thanks for the update! This has been added to the 1.12 Tracking sheet.

/assign @jsafrane /stage alpha

justaugustus avatar Jul 28 '18 08:07 justaugustus

Hey there! @saad-ali I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

zparnold avatar Aug 20 '18 20:08 zparnold

@jsafrane @vladimirvivien -- Any update on docs status for this feature? Are we still planning to land it for 1.12? At this point, code freeze is upon us, and docs are due on 9/7 (2 days). If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

justaugustus avatar Sep 05 '18 22:09 justaugustus

This PR (https://github.com/kubernetes/kubernetes/pull/67452) did not make it to 1.12. Moving to next milestone

saad-ali avatar Sep 06 '18 00:09 saad-ali

Thanks for the update!

justaugustus avatar Sep 06 '18 01:09 justaugustus

/assign vladimirvivien

vladimirvivien avatar Oct 09 '18 15:10 vladimirvivien

@saad-ali @vladimirvivien how confident are we about this going Alpha in 1.13? Is there a list of pending PRs or issues we are tracking for this work?

AishSundar avatar Oct 17 '18 05:10 AishSundar

@vladimirvivien there hasn't been any communication on this issue but from the looks of https://github.com/kubernetes/kubernetes/pull/68232 there is activity happening so this is going to continue to be tracked for v1.13 milestone.

kacole2 avatar Oct 22 '18 20:10 kacole2

Hi @vladimirvivien @jsafrane @saad-ali, I'm the docs wrangler for the 1.13 release. Could you please open a placeholder PR for the docs for this enhancement against the dev-1.13 branch of k/website and send me a link? If you already have a docs PR open, or if this doesn't require docs in k/website, please let me know.

The deadline for placeholder PRs for the 1.13 release is November 8. So it's important to make a docs PR as soon as possible.

If you have any questions about any of this, I'm happy to help. You can also message me on slack (I'm tfogo there too).

Thanks!

tfogo avatar Nov 01 '18 22:11 tfogo

Hi @vladimirvivien I'm an enhancements shadow checking in on how this issue is tracking - looks like lots of activity in the K/K PR. Code slush is on 11/9 and code freeze is coming up on 11/15 are you confident this issue will make those dates?

claurence avatar Nov 07 '18 14:11 claurence

Doc - https://github.com/kubernetes/website/pull/10934

vladimirvivien avatar Nov 09 '18 02:11 vladimirvivien

@tfogo for docs PR

AishSundar avatar Nov 09 '18 03:11 AishSundar

@vladimirvivien @saad-ali could you plz provide the latest update on this enhancement and status for 1.13 please. Is kubernetes/kubernetes#68232 is the only pending PR (code snd test).

AishSundar avatar Nov 12 '18 04:11 AishSundar

/milestone 1.14

kacole2 avatar Nov 14 '18 18:11 kacole2

@kacole2: The provided milestone is not valid for this repository. Milestones in this repository: [v1.13, v1.14]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 14 '18 18:11 k8s-ci-robot

/milestone v1.14

kacole2 avatar Nov 14 '18 18:11 kacole2

@saad-ali @jsafrane Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

claurence avatar Jan 16 '19 16:01 claurence

Yes, this is expected to be alpha in 1.14.

kfox1111 avatar Jan 16 '19 17:01 kfox1111

@kfox1111 @jsafrane I'll add it to the 1.14 tracking sheet. I don't see a KEP for this issue and we want to have KEPs for all issues in 1.14 - can you drop a link to the KEP?

claurence avatar Jan 16 '19 17:01 claurence

Yeah. it was started preKEP. We can try and get one in soon.

kfox1111 avatar Jan 16 '19 17:01 kfox1111

@claurence I will convert this into a KEP. Than you.

vladimirvivien avatar Jan 16 '19 17:01 vladimirvivien

@claurence KEP started here - https://github.com/kubernetes/enhancements/pull/716

vladimirvivien avatar Jan 23 '19 18:01 vladimirvivien

Thanks @vladimirvivien - any open PRs we should track for 1.14?

claurence avatar Jan 23 '19 18:01 claurence

Hey @vladimirvivien @jsafrane👋 I'm the v1.14 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

makoscafee avatar Feb 13 '19 06:02 makoscafee

@claurence https://github.com/kubernetes/kubernetes/pull/68232

@MAKOSCAFEE I think there was a docs pr opened when this almost merged in 1.13. I don't have the link handy though. @vladimirvivien do you?

kfox1111 avatar Feb 13 '19 16:02 kfox1111

@kfox1111 i think this is the PR you were talking about kubernetes/website#10934. If so can this be opened against dev-1.14 branch and looks like it has a lot of conflicts to resolve.

makoscafee avatar Feb 13 '19 17:02 makoscafee

That's the one I was thinking of. Thanks for finding it. We should update that, yeah.

kfox1111 avatar Feb 13 '19 18:02 kfox1111

@MAKOSCAFEE @kfox1111 there will definitely be updates to the doc, not sure if a new one will be created.

vladimirvivien avatar Feb 14 '19 17:02 vladimirvivien

** PRs to follow **

  • https://github.com/kubernetes/kubernetes/pull/74086

vladimirvivien avatar Feb 14 '19 17:02 vladimirvivien

@vladimirvivien thanks for the information. docs PR(or a placeholder PR) should be against dev-1.14 branch before March 1 which is the deadline. the sooner the better

makoscafee avatar Feb 14 '19 19:02 makoscafee