KEP 1645: add ServiceImport conditions

[MrFreezeex]

• One-line PR description: Add conditions field to ServiceImport resource

• Issue link: https://github.com/kubernetes/enhancements/issues/1645

• Other comments:

So far we had the conditions fields only on ServiceExport, trying to implement dual stack on Cilium and Submariner highlighted that there could be some "import time" errors as well. For instance, having an IPv6 only service and trying to import in IPv4 only clusters which in both Cilium and Submariner raise some issue that we would want to report to users via the ServiceImport conditions.

This is not specifically tied to IP protocol/families issues but supposed to be a general thing for implementations to report any errors and status occurring during import time.

[MrFreezeex]

/cc @tpantelis @mikemorris

I would bring this in the next sig meeting but if you have any comment and/or want to review this prior to the meeting feel free!

[mikemorris]

Agreed this makes sense as a general-purpose mechanism for surfacing issues which can not be discovered at export time.

/lgtm

[tpantelis]

/lgtm

[lauralorenz]

Triage notes:

• this PR is all additive to ServiceImport
• has lgtms from peeps who are involved
• despite bringing up https://github.com/kubernetes-sigs/mcs-api/issues/106 in context of this, we do think that this change can be made independently (its more of a philosophical data point into that other conversation)

[tpantelis]

/lgtm

[skitt]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~keps/sig-multicluster/OWNERS~~ [skitt]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment