enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

KEP 1645: relax the ServiceExportConflict requirements

Open tpantelis opened this issue 5 months ago • 5 comments

The KEP states that "a ServiceExportConflict condition will be set on all ServiceExports for the conflicted service", however this assumes an implementation has a central controller that has access to all the constituent ServiceExports or that each cluster has access to the ServiceExports on every other cluster but this may not be the case.

This PR modifies the language to recommend the condition be set on all ServiceExports but not require it.

See the motivation and further discussion here: https://github.com/kubernetes-sigs/mcs-api/pull/111#discussion_r2162096079

Issue link: Multi-Cluster Services API #1645

tpantelis avatar Jun 25 '25 14:06 tpantelis

/cc @MrFreezeex

tpantelis avatar Jun 25 '25 14:06 tpantelis

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrFreezeex, tpantelis Once this PR has been reviewed and has the lgtm label, please assign jeremyot for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 25 '25 14:06 k8s-ci-robot

/lgtm

Discussed in June 25th, 2025 SIG-Multicluster meeting, see notes at https://docs.google.com/document/d/18mk62nOXE_MCSSnb4yJD_8UadtzJrYyJxFwbrgabHe8/edit?tab=t.0#heading=h.gxm49ag2wja7

Thanks for updating this - definitely makes sense that the original language would have been much easier to implement in a centralized model.

mikemorris avatar Jun 25 '25 17:06 mikemorris

/cc @lauralorenz

tpantelis avatar Jun 26 '25 13:06 tpantelis

This looks good to me too, but if I approve it it will merge immediately, I would like feedback from more participants in the discussion :wink:.

skitt avatar Jun 26 '25 15:06 skitt

Based on discussion in the SIG meeting, the consensus is to keep the current language in the KEP wrt to conflict conditions and possibly make adjustments to ServiceImport to facilitate implementation if needed.

tpantelis avatar Jul 22 '25 13:07 tpantelis