enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

PSI-based node conditions

Open roycaihw opened this issue 6 months ago • 8 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Introduce node conditions based on PSI metrics.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/5395
  • Discussion Link: The original PSI KEP https://github.com/kubernetes/enhancements/issues/4205 contains two phases: 1) exposing PSI metrics and 2) PSI-based node conditions. This KEP is split from the original KEP to track phase 2, so that phase 1 and phase 2 can move at different paces. We plan to graduate phase 1 to Beta in 1.34. Phase 2 is yet to be developed and will stay Alpha in 1.34.
  • PRs by stage and milestone:
    • [ ] Alpha - v1.34
      • [ ] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/5395
      • [ ] Code (k/k) update PR(s):
      • [ ] Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig node /stage alpha /assign

roycaihw avatar Jun 10 '25 21:06 roycaihw

Hi @roycaihw Enhancements team here. Is this KEP planning for v1.34? If yes, you have to lead-opted-in, else release team won't be able to track this KEP. Thanks!

rayandas avatar Jun 12 '25 14:06 rayandas

/label lead-opted-in /milestone v1.34

I think this KEP should be used for using the PSI metrics, not for exposing them. 4205 should be for exposing them (as it already has been). I am opting in here though to put it on the board

haircommander avatar Jun 12 '25 21:06 haircommander

if we go along with ^ then it would be /stage alpha

here

haircommander avatar Jun 12 '25 21:06 haircommander

Hello @roycaihw 👋, v1.34 Enhancements team here again.

Just checking in as we approach Enhancements Freeze on 21:00 UTC Friday 20th June 2025.

This enhancement is targeting stage alpha for v1.34 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.34.
  • [ ] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on { PRR_FREEZE_DATETIME } so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • KEP merged to k/enhancements repo
  • PRR completed and merged

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

fykaa avatar Jun 13 '25 10:06 fykaa

@haircommander I've updated the two KEPs as suggested. PTAL

  • Existing KEP continues to track the exposure of PSI metrics: https://github.com/kubernetes/enhancements/issues/4205, https://github.com/kubernetes/enhancements/pull/5409
  • New KEP tracks the net new feature of PSI-based node conditions: https://github.com/kubernetes/enhancements/issues/5394, https://github.com/kubernetes/enhancements/pull/5395

roycaihw avatar Jun 17 '25 01:06 roycaihw

With all the requirements fulfilled, this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

/label tracked/yes

fykaa avatar Jun 20 '25 12:06 fykaa

Hi @roycaihw 👋 -- this is Dipesh (@dipesh-rawat) from the v1.34 Communications Team!

For the v1.34 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Friday 11th July? For more information about writing a blog, please find the blog contribution guidelines 📚

[!Tip] Some timeline to keep in mind:

  • 02:00 UTC Friday 11th July 2025: Feature blog PR freeze
  • Friday 8th August 2025: Feature blogs ready for review
  • You can find more in the release document

[!Note] In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

dipesh-rawat avatar Jun 21 '25 15:06 dipesh-rawat

Hi @roycaihw :wave:, Arvind here from v1.34 Docs Team.

Does this enhancement work planned for 1.34 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.34 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before the Docs placeholder/draft PR deadline - Thursday 3rd July 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.

Thank you for your work!

ArvindParekh avatar Jun 26 '25 15:06 ArvindParekh

Hi @roycaihw 👋,

Just a reminder to open a placeholder PR against dev-1.34 branch in the k/website repo (steps available here) for this KEP if it requires new or modifications to existing docs. The deadline for this is Thursday July 3 at 18:00 PDT!

Thanks,

Arvind

ArvindParekh avatar Jul 03 '25 05:07 ArvindParekh

Hey again @roycaihw 👋 v1.34 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 25th July 2025 .

Here's where this enhancement currently stands:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, I cannot find any PR that needs to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP)

If the implementation work for this enhancement is occurring out-of-tree (i.e., outside of k/k), please link the relevant PRs in the issue description for visiblity. Alternativelty, if you're unable to provide specific PR links, a confirmation that all out-of-tree implementation work is complete and merged will help us finalize tracking and maintain accuracy.

The status of this enhancement is marked as At risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

fykaa avatar Jul 04 '25 17:07 fykaa

Hi @roycaihw 👋, v1.34 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned previously (here), which is 02:00 UTC Friday 11th July 2025. To opt in, please let us know and open a Feature Blog placeholder PR against k/website by the deadline. If you have any questions, please feel free to reach out to us!

[!Tip] Some timeline to keep in mind:

  • 02:00 UTC Friday 11th July 2025: Feature blog PR freeze
  • Friday 8th August 2025: Feature blogs ready for review
  • You can find more in the release document

[!Note] In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

dipesh-rawat avatar Jul 07 '25 13:07 dipesh-rawat

Hi @roycaihw 👋🏻. Arvind here from the Docs Team. The PR Ready for Review deadline (July 29 - Tuesday) is upon us :)

Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 29th 2025 18:00 PST. Feel free to ping us if you have any questions. Thank you for your work!

ArvindParekh avatar Jul 20 '25 15:07 ArvindParekh

This feature is off-track for 1.34. Will revisit in 1.35.

roycaihw avatar Jul 22 '25 20:07 roycaihw

Per above comment, will set this to Deferred for 1.34

/milestone clear

jenshu avatar Jul 25 '25 00:07 jenshu

Hi @roycaihw :wave:, v1.35 Enhancements Lead here.

I am closing the v1.34 milestone now.

If you'd like to work on this enhancement in v1.35, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.35 using /milestone v1.35.

Thanks!

/remove-label lead-opted-in /remove-label tracked/yes

rayandas avatar Sep 16 '25 18:09 rayandas

@roycaihw were you planning on working on this in 1.35?

haircommander avatar Sep 24 '25 20:09 haircommander

@haircommander @SergeyKanzhelev I'm not sure if I have enough time to work on it in 1.35, but would still like to track it in 1.35 as best effort. The KEP was marked "implementable" in 1.34 so hopefully it's not too controversial

roycaihw avatar Oct 09 '25 23:10 roycaihw

I noticed this too late, we are passed the PRR freeze.

SergeyKanzhelev avatar Oct 10 '25 06:10 SergeyKanzhelev