enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Support for Direct Service Return (DSR) and overlay networking in Windows kube-proxy

Open marosset opened this issue 10 months ago • 30 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Support DSR and Overlay networking in Windows kube-proxy

  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/5100-windows-dsr-and-overlay-support

  • Discussion Link: https://youtu.be/AqGmNKG1AHc?si=S-1kzNICabbWIfDW&t=614 (and previous community meetings)

  • Primary contact (assignee): @marosset

  • Responsible SIGs: Windows, Networking

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y): 1.14
    • Beta release target (x.y): 1.33
    • Stable release target (x.y):
  • [x] Alpha

  • [x] Beta

    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/5112
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/130833
      • https://github.com/kubernetes/kubernetes/pull/130876
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/49904
  • [ ] Stable

    • [ ] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/5406
    • [ ] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/132108
    • [ ] Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

marosset avatar Jan 28 '25 21:01 marosset

/sig windows networking /stage beta /milestone v1.33

marosset avatar Jan 28 '25 21:01 marosset

@marosset: The label(s) sig/networking cannot be applied, because the repository doesn't have them.

In response to this:

/sig windows networking /stage beta /milestone v1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jan 28 '25 21:01 k8s-ci-robot

WinDSR and WinOverlay feature gates were added in K8s v1.14 and were introduced without a KEP. Both of these features gates are stable and used in many production environments. This enhancement will add a 'retroactive' KEP for DSR and Overlay support for Windows nodes documenting what the features enable and will be used to move the feature gates to stable in upcoming releases.

marosset avatar Jan 28 '25 22:01 marosset

/label lead-opted-in

marosset avatar Feb 03 '25 21:02 marosset

Hello @marosset 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage beta for v1.33 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.33.
  • [ ] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • [ ] I see that you have a PR open with some of these updates. Please also make sure to add an approver for beta in the PRR file.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

jenshu avatar Feb 04 '25 18:02 jenshu

Even though this is retroactive, the KEP title should explain the feature more than the retroactiveness. That makes https://www.kubernetes.dev/resources/keps/ most useful to readers.

sftim avatar Feb 10 '25 16:02 sftim

Hi @marosset 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/5100#issuecomment-2634740215 that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

dipesh-rawat avatar Feb 10 '25 20:02 dipesh-rawat

Hello @marosset :wave:, v1.33 Docs Shadow here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs? If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

hacktivist123 avatar Feb 12 '25 17:02 hacktivist123

Even though this is retroactive, the KEP title should explain the feature more than the retroactiveness. That makes https://www.kubernetes.dev/resources/keps/ most useful to readers.

@sftim - Is this comment in regards to the issue title? I'm just confirming where all to update.

marosset avatar Feb 12 '25 18:02 marosset

(yes, issue / KEP title)

sftim avatar Feb 12 '25 23:02 sftim

Hello @marosset 👋, v1.33 Enhancements team here.

With all the requirements fulfilled, this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

jenshu avatar Feb 13 '25 03:02 jenshu

Hello @marosset 👋, v1.33 Docs Shadow here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs? If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

Added https://github.com/kubernetes/website/pull/49904 as a placeholder thanks @hacktivist123

marosset avatar Feb 25 '25 20:02 marosset

Hi @marosset 👋 -- this is Ryota (@rytswd) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

[!Tip] Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

[!Note] In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

rytswd avatar Mar 01 '25 13:03 rytswd

Hi @marosset 👋, this is Sneha, from the 1.33 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 5th March, 2025. To opt in, please let us know and open a Feature Blog placeholder PR against [k/website](https://github.com/kubernetes/website) by the deadline. If you have any questions, please feel free to reach out to us!

[!Tip] Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the [release document](https://github.com/kubernetes/sig-release/tree/master/releases/release-1.33#timeline)

[!Note] In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

sn3hay avatar Mar 03 '25 23:03 sn3hay

Hey again @marosset 👋, v1.33 Enhancements team here.

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

As this is a retroactive KEP, can you confirm whether there are any new code changes that need to be merged into k/k for this release, and if so, can you please update the issue description above with the PR links?

In the meantime I will mark this as At risk for code freeze. Thanks!

jenshu avatar Mar 04 '25 04:03 jenshu

Hi @marosset 👋, v1.33 Enhancements team here,

Could you please confirm the question asked in the comment https://github.com/kubernetes/enhancements/issues/5100#issuecomment-2696200768 about any planned code changes for this release? This will help us update the approriate status for this KEP in the tracking board. Thanks!

dipesh-rawat avatar Mar 17 '25 17:03 dipesh-rawat

Hey again @marosset 👋, v1.33 Enhancements team here.

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

As this is a retroactive KEP, can you confirm whether there are any new code changes that need to be merged into k/k for this release, and if so, can you please update the issue description above with the PR links?

In the meantime I will mark this as At risk for code freeze. Thanks!

Sorry about the delay!.

Yes, there are some planned code changes to add unit-test coverage (https://github.com/kubernetes/kubernetes/pull/130833) and also to move the feature-gate to beta. (this one should get opened today).

Thanks! --Mark

marosset avatar Mar 17 '25 17:03 marosset

Hey @marosset @rzlink 👋, 1.33 Enhancements team here,

With all the implementation(code related) PRs merged as per the issue description:

  • https://github.com/kubernetes/kubernetes/pull/130876
  • https://github.com/kubernetes/kubernetes/pull/130833

This enhancement is now marked as tracked for code freeze for the 1.33 Code Freeze!

Additionally, please let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status.

dipesh-rawat avatar Mar 20 '25 15:03 dipesh-rawat

Hi @marosset 👋, 1.34 Enhancements Lead here.

I am closing the v1.33 milestone now.

If you'd like to work on this enhancement in v1.34, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.34 using /milestone v1.34.

Thanks!

/remove-label lead-opted-in /remove-label tracked/yes /milestone clear

jenshu avatar May 16 '25 16:05 jenshu

/label lead-opted-in /milestone v1.34

zylxjtu avatar Jun 03 '25 22:06 zylxjtu

@zylxjtu: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/label lead-opted-in /milestone v1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 03 '25 22:06 k8s-ci-robot

/milestone v1.34

zylxjtu avatar Jun 04 '25 16:06 zylxjtu

Hi @marosset @rzlink 👋, v1.34 Enhancements team here.

This is a reminder of the upcoming PRR Freeze on Thursday 12th June 2025.

By this date, there must be a PR open in k/enhancements with:

  • The KEP's PRR questionnaire filled out.
  • The kep.yaml updated with the stage, latest-milestone, and milestone struct filled out.
  • A PRR approval file with the PRR approver listed for the stage the KEP is targeting.

Having the PRR questionnaire filled out by this deadline will help ensure that the PRR team has enough time to review your KEP before Enhancements Freeze on Friday 20th June 2025. For more information on the PRR process, see here.

jenshu avatar Jun 06 '25 03:06 jenshu

Also, can you please confirm what stage this KEP is targeting in 1.34?

jenshu avatar Jun 06 '25 03:06 jenshu

@jenshu - we're targeting stable/GA for v1.34

marosset avatar Jun 10 '25 21:06 marosset

/stage stable

marosset avatar Jun 10 '25 21:06 marosset

Hello again @marosset 👋, v1.34 Enhancements team here.

Just checking in as we approach enhancements freeze on 21:00 UTC Friday 20th June 2025 / 14:00 PST Friday 20th June 2025.

This enhancement is targeting stage stable for v1.34 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.34.
  • [x] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 12th June 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • [ ] In your kep.yaml, can you please make the following updates:
    • stage = stable
    • latest-milestone = v1.34
    • milestone.stable = v1.34
  • [ ] In your PRR approval file can you please add an approver for stable?

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

jenshu avatar Jun 11 '25 04:06 jenshu

Hi @marosset @rzlink,

With all the requirements fulfilled, this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

/label tracked/yes

jenshu avatar Jun 18 '25 03:06 jenshu

Hi @marosset 👋 -- this is Agus (@aibarbetta) from the v1.34 Communications Team!

For the v1.34 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Friday 11th July? For more information about writing a blog, please find the blog contribution guidelines 📚

[!Tip] Some timeline to keep in mind:

  • 02:00 UTC Friday 11th July 2025: Feature blog PR freeze
  • Friday 8th August 2025: Feature blogs ready for review
  • You can find more in the release document

[!Note] In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

aibarbetta avatar Jun 24 '25 02:06 aibarbetta

Hi @marosset :wave:, Arvind here from v1.34 Docs Team.

Does this enhancement work planned for 1.34 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.34 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before the Docs placeholder/draft PR deadline - Thursday 3rd July 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.

Thank you for your work!

ArvindParekh avatar Jun 26 '25 14:06 ArvindParekh