enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard
verified publisher icon kubernetes

CSI Sidecars All in one

Open mowangdk opened this issue 1 year ago • 12 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): To combine the source code of the CSI sidecars in a monorepo.

  • Kubernetes Enhancement Proposal:

  • Discussion Link: google docs: https://docs.google.com/document/d/1z7OU79YBnvlaDgcvmtYVnUAYFX1w9lyrgiPTV7RXjHM/edit?tab=t.0

  • Primary contact (assignee): @mowangdk @mauriciopoppe @ConnorJC3

  • Responsible SIGs: /sig storage

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y): 1.34
    • Beta release target (x.y):
    • Stable release target (x.y):

  • [ ] Alpha

    • [ ] KEP (k/enhancements) update PR(s):
    • [ ] Code (k/k) update PR(s):
    • [ ] Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

mowangdk avatar Nov 10 '24 06:11 mowangdk

If we have n repos and combine some of them into a repo, it's not really a monorepo. Or rather, we can use that term, but it risks confusing people.

sftim avatar Nov 11 '24 09:11 sftim

Thank you for kicking the effort @mowangdk!

/cc

mauriciopoppe avatar Nov 11 '24 17:11 mauriciopoppe

If we have n repos and combine some of them into a repo, it's not really a monorepo. Or rather, we can use that term, but it risks confusing people.

any suggestions?

mowangdk avatar Nov 11 '24 23:11 mowangdk

("KEP" in the title of the issue is redundant and the issue number is already the identifier for this page)

BenTheElder avatar Nov 18 '24 05:11 BenTheElder

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 16 '25 05:02 k8s-triage-robot

/remove-lifecycle stale

mowangdk avatar Feb 17 '25 11:02 mowangdk

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 18 '25 11:05 k8s-triage-robot

/remove-lifecycle stale

mowangdk avatar May 18 '25 14:05 mowangdk

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 16 '25 14:08 k8s-triage-robot

/remove-lifecycle stale

mowangdk avatar Aug 17 '25 03:08 mowangdk

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 15 '25 04:11 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Dec 15 '25 04:12 k8s-triage-robot

This KEP does not handle leader election locks that were held by different components before upgrade and hence would allow parallel running of two resizers, provisioners etc. Which may be pretty bad for certain deployments on upgrade. This needs to be fixed.

gnufied avatar Dec 17 '25 21:12 gnufied

This KEP does not handle leader election locks that were held by different components before upgrade and hence would allow parallel running of two resizers, provisioners etc. Which may be pretty bad for certain deployments on upgrade. This needs to be fixed.

Indeed, we discussed this with Jan in KEP comments, and will add it in upcoming pr.

mowangdk avatar Dec 17 '25 23:12 mowangdk