enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Add PSA to block setting `.host` field from ProbeHandler and LifecycleHandler

Open tssurya opened this issue 1 year ago β€’ 17 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add PSA to block setting .host field from ProbeHandler and LifecycleHandler
  • Kubernetes Enhancement Proposal:
  • Discussion Link:
    • https://github.com/kubernetes/kubernetes/issues/99425
    • https://docs.google.com/document/d/1lpVI4OuxRf7-j2jcfHm48MdHyxMR5PlKyWzAO-NUYgU/edit?tab=t.0#heading=h.sk3qw3odtcg3
    • https://docs.google.com/document/d/1woLGRoONE3EBVx-wTb4pvp4CI7tmLZ6lS26VTbosLKM/edit?tab=t.0#bookmark=id.kn6d9d9e97kw
  • Primary contact (assignee): @tssurya
  • Responsible SIGs: sig-auth
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.34
    • Beta release target (x.y):
    • Stable release target (x.y):
  • [ ] Alpha
    • [ ] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4942
    • [ ] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/125271
    • [ ] Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig auth

tssurya avatar Oct 31 '24 16:10 tssurya

/assign @tssurya

tssurya avatar Oct 31 '24 16:10 tssurya

/sig auth

tssurya avatar Oct 31 '24 16:10 tssurya

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 29 '25 18:01 k8s-triage-robot

/cc @bowei

bowei avatar Jan 29 '25 19:01 bowei

/remove-lifecycle stale

tssurya avatar Feb 02 '25 16:02 tssurya

Attempting alpha for 1.34

liggitt avatar Apr 28 '25 14:04 liggitt

Hi @tssurya πŸ‘‹, v1.34 Enhancements Lead here.

It looks like this enhancement has been added to the v1.34 milestone, but doesn't yet have the lead-opted-in label. Just a gentle reminder that if you plan to work on this enhancement in v1.34, please have the SIG lead opt-in by adding the lead-opted-in label, which will ensure it gets added to the tracking board.

Thanks!

jenshu avatar May 16 '25 21:05 jenshu

Hi @tssurya πŸ‘‹, v1.34 Enhancements Lead here.

It looks like this enhancement has been added to the v1.34 milestone, but doesn't yet have the lead-opted-in label. Just a gentle reminder that if you plan to work on this enhancement in v1.34, please have the SIG lead opt-in by adding the lead-opted-in label, which will ensure it gets added to the tracking board.

Thanks!

@deads2k or @liggitt is this something one of you can help with?

tssurya avatar May 17 '25 20:05 tssurya

/label lead-opted-in

liggitt avatar May 20 '25 13:05 liggitt

Hi @tssurya πŸ‘‹, v1.34 Enhancements team here.

This is a reminder of the upcoming PRR Freeze on Thursday 12th June 2025.

By this date, there must be a PR open in k/enhancements with:

  • The KEP's PRR questionnaire filled out.
  • The kep.yaml updated with the stage, latest-milestone, and milestone struct filled out.
  • A PRR approval file with the PRR approver listed for the stage the KEP is targeting.

Having the PRR questionnaire filled out by this deadline will help ensure that the PRR team has enough time to review your KEP before Enhancements Freeze on Friday 20th June 2025. For more information on the PRR process, see here.

rayandas avatar Jun 06 '25 03:06 rayandas

Hello again @tssurya :wave:, v1.34 Enhancements team here.

Just checking in as we approach enhancements freeze on 21:00 UTC Friday 20th June 2025 / 14:00 PST Friday 20th June 2025.

This enhancement is targeting stage alpha for v1.34 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.34.
  • [ ] KEP readme has up-to-date graduation criteria.
  • [ ] KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would need to update the following:

  • I notice that you have a PR up but it doesn't include PRR changes. Please update it and get a PRR review.

The status of this enhancement is marked as At risk enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

rayandas avatar Jun 11 '25 07:06 rayandas

Hello @tssurya, v1.34 Enhancements team here.

Just a friendly reminder that the enhancements freeze is on 21:00 UTC Friday 20th June 2025 / 14:00 PST Friday 20th June 2025.

I see there's a PR up for this but the PRR request is missing. Please follow this guide to add a Production Readiness Review.

This KEP is marked as At risk enhancements freeze at the moment.

rayandas avatar Jun 18 '25 06:06 rayandas

As the PR is now merged, marking it as Tracked for enhancements freeze

rayandas avatar Jun 20 '25 18:06 rayandas

/label tracked/yes

rayandas avatar Jun 21 '25 11:06 rayandas

Hi @nabokihms @tssurya πŸ‘‹ -- this is Graziano (@graz-dev) from the 1.34 Communications Team!

For the 1.34 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail πŸŽ‰

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Friday 11th July? For more information about writing a blog, please find the blog contribution guidelines πŸ“š

[!Tip] Some timeline to keep in mind:

  • 02:00 UTC Friday 11th July 2025: Feature blog PR freeze
  • Friday 8th August 2025: Feature blogs ready for review
  • You can find more in the release document

[!Note] In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

graz-dev avatar Jun 22 '25 15:06 graz-dev

Hello @nabokihms @tssurya πŸ‘‹, 1.34 Docs Shadow here!

Does this enhancement work planned for 1.34 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.34 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 3rd July 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

rashansmith avatar Jun 27 '25 00:06 rashansmith

Hi @rashansmith thanks for the link. Will take a look and confirm.

tssurya avatar Jun 27 '25 05:06 tssurya

Hello @nabokihms @tssurya πŸ‘‹, 1.34 Docs Shadow here!

Does this enhancement work planned for 1.34 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.34 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 3rd July 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Just a reminder to open a placeholder PR against dev-1.34 branch in the k/website repo for this (steps available here) for this KEP if it requires new or modifications to existing docs:

The deadline for this is Thursday July 3 at 18:00 PDT. Thanks! πŸš€

rashansmith avatar Jul 02 '25 20:07 rashansmith

Hello @nabokihms @tssurya πŸ‘‹, 1.34 Docs Shadow here! Does this enhancement work planned for 1.34 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.34 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 3rd July 2025 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

Just a reminder to open a placeholder PR against dev-1.34 branch in the k/website repo for this (steps available here) for this KEP if it requires new or modifications to existing docs:

The deadline for this is Thursday July 3 at 18:00 PDT. Thanks! πŸš€

thanks for the reminder again! that really helped me... opened a draft PR: https://github.com/kubernetes/website/pull/51498 as instructed in the docs that should be tracked for 1.34. hope that suffices!

tssurya avatar Jul 03 '25 11:07 tssurya

Hi @nabokihms @tssurya πŸ‘‹, 1.34 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Friday 11th July 2025. To opt in, please let us know and open a Feature Blog placeholder PR against k/website by the deadline. If you have any questions, please feel free to reach out to us!

[!Tip] Some timeline to keep in mind:

  • 02:00 UTC Friday 11th July 2025: Feature blog PR freeze
  • Friday 8th August 2025: Feature blogs ready for review
  • You can find more in the release document

[!Note] In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

graz-dev avatar Jul 04 '25 10:07 graz-dev

Hey again @nabokihms @tssurya, πŸ‘‹ v1.34 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 25th July 2025.

Here's where this enhancement currently stands:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze:

  • https://github.com/kubernetes/kubernetes/pull/125271

If the implementation work for this enhancement is occurring out-of-tree (i.e., outside of k/k), please link the relevant PRs in the issue description for visibility.

Alternatively, if you're unable to provide specific PR links, a confirmation that all out-of-tree implementation work is complete and merged will help us finalize tracking and maintain accuracy.

The status of this enhancement is marked as At risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance.

Please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

rayandas avatar Jul 10 '25 06:07 rayandas

Hi @nabokihms @tssurya πŸ‘‹, 1.34 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Friday 11th July 2025. To opt in, please let us know and open a Feature Blog placeholder PR against k/website by the deadline. If you have any questions, please feel free to reach out to us!

Tip

Some timeline to keep in mind:

  • 02:00 UTC Friday 11th July 2025: Feature blog PR freeze
  • Friday 8th August 2025: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

no we don't plan to do any blogs, thank you!

tssurya avatar Jul 10 '25 20:07 tssurya

Hello @nabokihms @tssurya :wave: please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 29th 2025 18:00 PST. Thank you!

rashansmith avatar Jul 20 '25 20:07 rashansmith

Looks like this issue was accidentally closed

jenshu avatar Jul 24 '25 23:07 jenshu

Since https://github.com/kubernetes/kubernetes/pull/125271 has merged, this is now tracked for code freeze!

jenshu avatar Jul 24 '25 23:07 jenshu

Hi @tssurya :wave:, v1.35 Enhancements Lead here.

I am closing the v1.34 milestone now.

If you'd like to work on this enhancement in v1.35, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.35 using /milestone v1.35.

Thanks!

/remove-label lead-opted-in /remove-label tracked/yes /milestone clear

rayandas avatar Sep 17 '25 12:09 rayandas

@rayandas : Hi! the work already finished in 1.34 already. Was there something specific I needed to do? please add it back to 1.34 milestone since all the work was already done and the issue was correctly closed by the bot. I didn't notice that it got reopened manually,,, not sure why though?

tssurya avatar Sep 17 '25 12:09 tssurya

Looks like this issue was accidentally closed

I don't know why this issue was reopened @jenshu ?

tssurya avatar Sep 17 '25 12:09 tssurya

https://github.com/kubernetes/enhancements/pull/5539 will mark as implemented and then close this issue

liggitt avatar Sep 17 '25 13:09 liggitt

actually, looks like this kep.yaml never got marked as implementable, so never triggered an official production readiness review file ... need to handle that first

liggitt avatar Sep 17 '25 13:09 liggitt