enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

KEP 1645: add labels and annotations export

Open MrFreezeex opened this issue 1 year ago • 2 comments

  • One-line PR description: add labels and annotations export
  • Issue link: https://github.com/kubernetes/enhancements/issues/1645
  • Other comments: Add new fields in the ServiceExport resources to sync labels and annotations. This approach is inspired by the GatewayAPI (https://gateway-api.sigs.k8s.io/geps/gep-1762/#labels-and-annotations) one to have dedicated fields for that and there's some explanation inline in the KEP why we might favor that.

MrFreezeex avatar Oct 16 '24 13:10 MrFreezeex

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Oct 16 '24 13:10 k8s-ci-robot

/approve

@mikemorris, @JeremyOT, @lauralorenz could you take a look (after Thanksgiving week-end I imagine :wink:)?

skitt avatar Nov 28 '24 15:11 skitt

Will prioritize reviewing this and kubernetes-sigs/mcs-api/pull/85 this week.

mikemorris avatar Dec 10 '24 03:12 mikemorris

This looks good to me, thank you!

/lgtm /approve

JeremyOT avatar Dec 11 '24 05:12 JeremyOT

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeremyOT, mikemorris, MrFreezeex, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 11 '24 05:12 k8s-ci-robot