enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Flagz for Kubernetes Components

Open richabanker opened this issue 1 year ago • 23 comments

Enhancement Description

  • Introduces a flagz page for all core components.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/4828-component-flagz/README.md
  • Discussion Link: link
  • Primary contact (assignee): @richabanker
  • Responsible SIGs: sig-instrumentation
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.32
    • Beta release target (x.y):
    • Stable release target (x.y):
  • [ ] Alpha
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4831
    • [x] Code (k/k) update PR(s):
      • [x] https://github.com/kubernetes/kubernetes/pull/127206
      • [x] https://github.com/kubernetes/kubernetes/pull/127581
      • [x] https://github.com/kubernetes/kubernetes/pull/128848
      • [x] https://github.com/kubernetes/kubernetes/pull/128857
      • [x] https://github.com/kubernetes/kubernetes/pull/128818
      • [x] https://github.com/kubernetes/kubernetes/pull/128824
      • [x] https://github.com/kubernetes/kubernetes/pull/128985
      • [x] https://github.com/kubernetes/kubernetes/pull/128925
    • [ ] Docs (k/website) update PR(s):
      • [x] https://github.com/kubernetes/website/pull/48760
      • [ ] https://github.com/kubernetes/website/pull/48369

richabanker avatar Sep 06 '24 18:09 richabanker

/assign

richabanker avatar Sep 06 '24 18:09 richabanker

/sig instrumentation

richabanker avatar Sep 06 '24 18:09 richabanker

Hello @richabanker 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise)

/stage alpha

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: v1.32.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • Create the KEP readme using the latest template and merge it in the k/enhancements repo.
  • Ensure that the KEP has undergone a production readiness review and has been merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

dipesh-rawat avatar Sep 24 '24 22:09 dipesh-rawat

Hello, I'd like to shadow PRR review here, thanks!

mattbailey avatar Oct 07 '24 21:10 mattbailey

Hi @richabanker 👋, v1.32 Enhancements team here.

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

The current status of this enhancement is marked as at risk for enhancement freeze. There are a few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/4828#issuecomment-2372521193 that still need to be completed.

It looks like PR https://github.com/kubernetes/enhancements/pull/4831 will address most of these issues. The PR https://github.com/kubernetes/enhancements/pull/4831 needs to be merged before the enhancements freeze.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

dipesh-rawat avatar Oct 08 '24 17:10 dipesh-rawat

Hello @richabanker 👋, v1.32 Enhancements team here,

Now that PR https://github.com/kubernetes/enhancements/pull/4831 has been merged, all the KEP requirements are in place and merged into k/enhancements.

Before the enhancement freeze, it would be appreciated if following nits could be addressed:

  • Update issue description to add direct link to KEP README.md.

    • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/4828-component-flagz/README.md

Aside from the minor nit mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

dipesh-rawat avatar Oct 09 '24 23:10 dipesh-rawat

@dipesh-rawat sure, I updated the issue description to point to the KEP readme. Thanks!

richabanker avatar Oct 10 '24 00:10 richabanker

@dgrisonnet should we add the milestone v1.32?

pacoxu avatar Oct 12 '24 10:10 pacoxu

@pacoxu thank you for checking, I was under the assumption we already added it

dgrisonnet avatar Oct 12 '24 11:10 dgrisonnet

Hello @richabanker , 👋🏼 this is Edith from the v1.32 Communications Team!

We’d love for you to consider writing a feature blog about your enhancement! ✍ Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024 🗓 . For more information about writing a blog, see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

edithturn avatar Oct 14 '24 03:10 edithturn

Hello @richabanker :wave:, 1.32 Docs Shadow here. Does this enhancement work planned for 1.32 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

rdalbuquerque avatar Oct 15 '24 10:10 rdalbuquerque

@rdalbuquerque Created a docs PR here https://github.com/kubernetes/website/pull/48368, thanks!

richabanker avatar Oct 15 '24 18:10 richabanker

@edithturn Created a blog PR here https://github.com/kubernetes/website/pull/48369, thanks!

richabanker avatar Oct 15 '24 18:10 richabanker

Hey again @richabanker 👋 v1.32 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

Here's where this enhancement currently stands:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

  • https://github.com/kubernetes/kubernetes/pull/127581
  • https://github.com/kubernetes/kubernetes/pull/127206

Additionally, please let me know if there are any other PRs in k/k not listed in the description or not linked with this GitHub issue that we should track for this KEP, so that we can maintain accurate status.

The status of this enhancement is marked as at risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

dipesh-rawat avatar Oct 21 '24 00:10 dipesh-rawat

Hey again @richabanker 👋, v1.32 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in few days, at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

The current status of this enhancement is marked as at risk for code freeze. There are a few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/4828#issuecomment-2425330410 that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance.

dipesh-rawat avatar Nov 05 '24 01:11 dipesh-rawat

Hello @richabanker 👋, v1.32 Enhancements team here

With all the implementation(code related) PRs merged as per the issue description:

  • https://github.com/kubernetes/kubernetes/pull/127206
  • https://github.com/kubernetes/kubernetes/pull/127581

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!

dipesh-rawat avatar Nov 08 '24 14:11 dipesh-rawat

Hello @richabanker 👋, v1.32 Comms team here,

Thank you for creating a placeholder PR for a feature blog!

The deadline for completing blog content to be Ready for Review is Monday 25th November 2024 . For more information about writing a blog see the blog contribution guidelines.

Please feel free to reach out if you have any questions!

rashansmith avatar Nov 15 '24 13:11 rashansmith

Hi @richabanker ! Can you please update the docs PR link in the issue description?

Thanks!

rdalbuquerque avatar Nov 19 '24 00:11 rdalbuquerque

@rdalbuquerque done!

richabanker avatar Nov 19 '24 00:11 richabanker

/reopen

https://github.com/kubernetes/kubernetes/pull/128848 seems to be part of beta process.

pacoxu avatar Dec 24 '24 10:12 pacoxu

@pacoxu: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Dec 24 '24 10:12 k8s-ci-robot

Hello @richabanker 👋, 1.33 Enhancements Lead here.

I’m closing milestone 1.32 now. If you'd like to work on this enhancement in v1.33, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.33 using /milestone v1.33. Thanks!

/remove-label lead-opted-in /milestone clear

dipesh-rawat avatar Jan 12 '25 19:01 dipesh-rawat

This will not be moved to beta in 1.33. It will be extended to other components beyond the API Server

dashpole avatar Jan 16 '25 17:01 dashpole

/milestone v1.35 /lead-opted-in

richabanker avatar Sep 11 '25 16:09 richabanker

/label lead-opted-in

richabanker avatar Sep 12 '25 20:09 richabanker

Hello @richabanker 👋, v1.35 Enhancements team here.

This is a reminder of the upcoming PRR freeze on Thursday 9th October 2025 (AoE) / Friday 10th October 2025, 12:00 UTC.

This enhancement is targeting stage alpha for v1.35 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] PR open or merged with the KEP's PRR questionnaire filled out.
  • [x] PR open or merged with kep.yaml updated with the stage, latest-milestone, and milestone struct filled out.
  • [ ] PR open or merged with a PRR approval file with the PRR approver listed for the stage the KEP is targeting.

For this KEP, we would just need to update the following:

  • Raise a PR to add the PRR approver for the milestone you're targeting this release cycle

Note that the PRs are not required to be approved or merged by the PRR freeze deadline. Having the PRR questionnaire filled out by the deadline will help ensure that the PRR team has enough time to review your KEP before enhancements freeze on Thursday 16th October 2025 (AoE) / Friday 17th October 2025, 12:00 UTC. For more information on the PRR process, see here.

The status of this enhancement is marked as At risk for PRR freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing PRR freeze, you can file an exception request in advance. Thank you!

chanieljdan avatar Oct 05 '25 19:10 chanieljdan

@chanieljdan the PRR approval file will not change in 1.35 since we are introducing the new structured API while keeping this feature in alpha.

richabanker avatar Oct 06 '25 21:10 richabanker

Apologies, you are correct. This PR (https://github.com/kubernetes/enhancements/issues/4828) checks all the requirements for PRR freeze, hence this KEP is now Tracked for PRR freeze. Thanks! /label tracked/yes

chanieljdan avatar Oct 10 '25 03:10 chanieljdan

Hello @richabanker 👋, v1.35 Enhancements team here.

Just checking in as we approach enhancements freeze on Thursday 16th October 2025 (AoE) / Friday 17th October 2025, 12:00 UTC.

This enhancement is targeting stage alpha for v1.35 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: v1.35. KEPs targeting stable will need to be marked as implemented after code PRs are merged.
  • [X] KEP readme has up-to-date graduation criteria.
  • [X] KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as Tracked for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

chanieljdan avatar Oct 14 '25 20:10 chanieljdan

Hello @richabanker 👋, v1.35 Docs Lead here.

Does this enhancement work planned for v1.35 require any new docs or modification to existing docs? If so, please follow the steps here to open a PR against dev-1.35 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 23th October 2025. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Urvashi0109 avatar Oct 15 '25 05:10 Urvashi0109