KEP-4764: Kubectl supports WatchList to list resources

[xuzhenglun]

• One-line PR description: kubectl supports WatchList to list resources

• Issue link: https://github.com/kubernetes/enhancements/issues/4764

• Other comments:

[xuzhenglun]

/hold

I just found that WatchList method has been merged into client-go in https://github.com/kubernetes/kubernetes/pull/122657, so maybe we can dependent on it and avoid to implement it again.

But there is a problem(see https://github.com/kubernetes/kubernetes/issues/126206) with the current implementation, that is, when ServerPrint is enabled, the k8s.io/initial-events-end=true annotation is on the metav1.Table.Rows instead of the top metav1.Table object. Maybe we should wait for a fix on the api side?

[wojtek-t]

/cc @p0lyn0mial @deads2k

[xuzhenglun]

@wojtek-t @p0lyn0mial @deads2k @sftim

Hi 👋 , Is anything else I need to do yet? It's will be nice if this proposal could reach the next 1.32 dev cycle.

Any suggestion I will be really appreciate.

[xuzhenglun]

/reopen

[k8s-ci-robot]

@xuzhenglun: Failed to re-open PR: state cannot be changed. There are no new commits on the xuzhenglun:master branch.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[xuzhenglun]

/reopen

[k8s-ci-robot]

@xuzhenglun: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xuzhenglun Once this PR has been reviewed and has the lgtm label, please assign eddiezane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• keps/sig-cli/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xuzhenglun Once this PR has been reviewed and has the lgtm label, please assign eddiezane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• keps/sig-cli/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[xuzhenglun]

sorry for the noise of closing and reopening, there was a slight problem when I was doing rebase.

I was thinking about the environment variable naming thing. As a kubectl feature, I still feel it will be better to use KUBECTL_ prefix and follow the customs of kubectl feature-gate.

PTAL is there anything need to do, I really want to make this happen in the next release cycle.

/cc @mpuckett159 @eddiezane @soltysh @p0lyn0mial

[p0lyn0mial]

@xuzhenglun Hey, I think we should hold off on this KEP until the streaming feature graduates to Beta. There are still things that need to be fixed, which might slightly change the code, especially on the client side. For the streaming API, we are targeting 1.32.

[xuzhenglun]

sure, as the conclusion in the last sig-cli meeting, this KEP will not merge any code only until watchlist is promoted into beta.  https://docs.google.com/document/u/0/d/1I1UFGHMDO7mMbDbioQp52DEJXEhk1qymch3qL5-EN10/mobilebasic

Please take your time to deal with that, and I will continue this enhancement once it’s resolved. Thank you.

[xuzhenglun]

hi @soltysh, since WatchList has been promoted into Beta in https://github.com/kubernetes/kubernetes/pull/128053, would you kindly review this enhanment please? 🙏

[soltysh]

hi @soltysh, since WatchList has been promoted into Beta in kubernetes/kubernetes#128053, would you kindly review this enhanment please? 🙏

I'll try to find some time in the next weeks, but most likely after KubeCon NA.

[xuzhenglun]

hi @soltysh, since v1.32 has released, could you please kindly review this enhancement if it's possible.

[xuzhenglun]

Hi, @soltysh

could you please take a look this if possiable? or does some else could help to review this enhancement?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[soltysh]

Based on discussion it seems the WatchList feature on the server was disabled in 1.33, and its future is still not clear. Let's wait for until apimachinery gets a conclusion on the future of this feature before we'll consider adding this to kubectl.

/hold

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[xuzhenglun]

since the future of WatchList mechanism is not clear just like soltysh said, this enhancement may not go on. if any progress has, I'm happy to continue on this and reopen this later.