enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Allows setting any FQDN as the pod's hostname

Open HirazawaUi opened this issue 1 year ago β€’ 17 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Allows users to set any FQDN as the hostname of a pod
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/4768
  • Discussion Link: https://github.com/kubernetes/kubernetes/issues/97662
  • Primary contact (assignee): @HirazawaUi
  • Responsible SIGs: network
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.33
    • Beta release target (x.y):
    • Stable release target (x.y):
  • [ ] Alpha
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4768
    • [ ] Code (k/k) update PR(s):
    • [ ] Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

HirazawaUi avatar Jul 15 '24 15:07 HirazawaUi

/sig network

HirazawaUi avatar Jul 15 '24 15:07 HirazawaUi

Is not a duplicate of https://github.com/kubernetes/enhancements/issues/1797 ?

aojea avatar Jul 16 '24 11:07 aojea

Is not a duplicate of #1797 ?

The goal of this kep is to allow arbitrary FQDN to be set as hostname for pod, #1797 only allows setting pod hostname to FQDN.

HirazawaUi avatar Jul 16 '24 13:07 HirazawaUi

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 19 '25 13:01 k8s-triage-robot

/remove-lifecycle stale

HirazawaUi avatar Jan 20 '25 14:01 HirazawaUi

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 20 '25 15:04 k8s-triage-robot

/remove-lifecycle stale

HirazawaUi avatar Apr 21 '25 12:04 HirazawaUi

I was scanning KEPs for updates and I found the PR for this and I have a bunch of unsent comments!!!

I am so sorry, I didn't mean to ignore it, I actually spent time on it and never sent. I will revisit today and send.

thockin avatar May 18 '25 16:05 thockin

Hi @HirazawaUi :wave:, v1.34 Enhancements team here.

This is a reminder of the upcoming PRR Freeze on Thursday 12th June 2025.

By this date, there must be a PR open in k/enhancements with:

  • The KEP's PRR questionnaire filled out.
  • The kep.yaml updated with the stage, latest-milestone, and milestone struct filled out.
  • A PRR approval file with the PRR approver listed for the stage the KEP is targeting.

Having the PRR questionnaire filled out by this deadline will help ensure that the PRR team has enough time to review your KEP before Enhancements Freeze on Friday 20th June 2025. For more information on the PRR process, see here.

stmcginnis avatar Jun 09 '25 14:06 stmcginnis

Hello @HirazawaUi πŸ‘‹, v1.34 Enhancements team here again.

Just checking in as we approach Enhancements Freeze on 21:00 UTC Friday 20th June 2025.

This enhancement is targeting stage alpha for v1.34 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.34.
  • [ ] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on { PRR_FREEZE_DATETIME } so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • KEP merged to k/enhancements repo
  • PRR completed and merged

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

stmcginnis avatar Jun 11 '25 18:06 stmcginnis

@HirazawaUi can you make sure all these checkboxes get completed?

thockin avatar Jun 11 '25 20:06 thockin

@HirazawaUi can you make sure all these checkboxes get completed?

It looks like PRR approval is all we need now. I'll actively try to get this KEP on the radar of the PRR approvers.

HirazawaUi avatar Jun 12 '25 00:06 HirazawaUi

Hey πŸ‘‹ - just a friendly reminder that enhancement freeze is coming up in just a few days. If we know this enhancement will not make it for 1.34, please remove or update the target milestone.

Also a reminder that, if necessary, you can file a freeze exception request. Thanks!

stmcginnis avatar Jun 17 '25 17:06 stmcginnis

I see the KEP/PRR merged! πŸŽ‰ Updating status to being tracked.

stmcginnis avatar Jun 20 '25 20:06 stmcginnis

Hi @HirazawaUi ,@thockin πŸ‘‹ -- this is Alejandro Leon (@88abb) from the 1.34 Communications Team!

For the 1.34 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail πŸŽ‰

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Friday 11th July? For more information about writing a blog, please find the blog contribution guidelines πŸ“š

[!Tip] Some timeline to keep in mind:

  • 02:00 UTC Friday 11th July 2025: Feature blog PR freeze
  • Friday 8th August 2025: Feature blogs ready for review
  • You can find more in the release document

[!Note] In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

88abb avatar Jun 25 '25 13:06 88abb

Hi @HirazawaUi @thockin :wave:, Arvind here from v1.34 Docs Team.

Does this enhancement work planned for 1.34 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.34 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before the Docs placeholder/draft PR deadline - Thursday 3rd July 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.

Thank you for your work!

ArvindParekh avatar Jun 26 '25 15:06 ArvindParekh

@ArvindParekh Thank you for the reminder. I have created a placeholder PR for the documentation in the k/website repo.

ref: https://github.com/kubernetes/website/pull/51414

HirazawaUi avatar Jun 28 '25 15:06 HirazawaUi

Hey again @HirazawaUi πŸ‘‹, 1.34 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 25th July 2025 .

Here's where this enhancement currently stands:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the description includes links to code changes. Can you update that to add all necessary PRs and any other details needed to see the current KEP implementation status?

If the implementation work for this enhancement is occurring out-of-tree (i.e., outside of k/k), please link the relevant PRs in the issue description for visibility. Alternatively, if you're unable to provide specific PR links, a confirmation that all out-of-tree implementation work is complete and merged will help us finalize tracking and maintain accuracy.

The status of this enhancement is marked as At risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

stmcginnis avatar Jul 03 '25 19:07 stmcginnis

Hi @HirazawaUi @thockin πŸ‘‹, v1.34 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Friday 11th July. To opt in, please let us know and open a Feature Blog placeholder PR against k/website by the deadline. If you have any questions, please feel free to reach out to us!

[!Tip] Some timeline to keep in mind:

  • 02:00 UTC Friday 11th July 2025: Feature blog PR freeze
  • Friday 8th August 2025: Feature blogs ready for review
  • You can find more in the release document

[!Note] In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

aibarbetta avatar Jul 09 '25 12:07 aibarbetta

Hi @HirazawaUi @thockin πŸ‘‹πŸ». Arvind here from the Docs Team. The PR Ready for Review deadline (July 29 - Tuesday) is upon us :)

Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 29th 2025 18:00 PST. Feel free to ping us if you have any questions. Thank you for your work!

ArvindParekh avatar Jul 20 '25 15:07 ArvindParekh

@HirazawaUi it looks like all k/k code PRs are merged (let me know if that is not the case). This is now tracked for code freeze!

jenshu avatar Jul 25 '25 00:07 jenshu

An exception request was opened (and approved), due to an additional PR needed: https://github.com/kubernetes/kubernetes/pull/133254. Since this PR has merged, we are setting this back to Tracked for code freeze

jenshu avatar Jul 30 '25 00:07 jenshu

Hi @HirazawaUi :wave:, v1.35 Enhancements Lead here.

I am closing the v1.34 milestone now.

If you'd like to work on this enhancement in v1.35, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.35 using /milestone v1.35.

Thanks!

/remove-label lead-opted-in /remove-label tracked/yes /milestone clear

rayandas avatar Sep 17 '25 12:09 rayandas

Yes, I will push this feature to the beta stage in version v1.35.

HirazawaUi avatar Sep 17 '25 13:09 HirazawaUi

@thockin @aojea May I ask who I should contact to add the lead-opted-in label?

HirazawaUi avatar Sep 17 '25 13:09 HirazawaUi

ping @thockin, could you please add the lead-opted-in label to this issue? I've already opened the PR for the beta phase. :)

HirazawaUi avatar Oct 08 '25 11:10 HirazawaUi

/stage beta /assign @HirazawaUi

(correcting some metadata. Since it is sig network, I would let leads of sig network to add to the milestone)

SergeyKanzhelev avatar Oct 08 '25 16:10 SergeyKanzhelev

ping @thockin, could you please add the lead-opted-in label to this issue? I've already opened the PR for the beta phase. :)

ping @danwinship

HirazawaUi avatar Oct 08 '25 23:10 HirazawaUi

/label lead-opted-in /milestone v1.35

danwinship avatar Oct 09 '25 11:10 danwinship

Hello @rayandas, could you please help with the tracking this KEP for the 1.35 cycle. Many thanks for your help in advance!

I know the KEP will utlimately land on the release team tracking board with the automation, but pinging proactively ahead of today’s PRR freeze timeline.


Update: PR making the KEP updates for beta graduation - https://github.com/kubernetes/enhancements/pull/5636

Priyankasaggu11929 avatar Oct 09 '25 11:10 Priyankasaggu11929