enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

KEP-4743: Kubernetes-etcd interface

Open serathius opened this issue 1 year ago • 9 comments

  • One-line PR description: Moving https://docs.google.com/document/d/1-nIpoW87qqQ9FxINOzXPkhu7CD_FWW1piYqHZDr39nU/edit?usp=sharing to KEP

  • Issue link: https://github.com/kubernetes/enhancements/issues/4743

  • Other comments:

/cc @ahrtr @wojtek-t @dims @jpbetz @deads2k

serathius avatar Jun 28 '24 13:06 serathius

@serathius: GitHub didn't allow me to request PR reviews from the following users: dead2k.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

  • One-line PR description: Moving https://docs.google.com/document/d/1-nIpoW87qqQ9FxINOzXPkhu7CD_FWW1piYqHZDr39nU/edit?usp=sharing to KEP

  • Issue link: https://github.com/kubernetes/enhancements/issues/4743

  • Other comments:

/cc @ahrtr @wojtek-t @dims @jpbetz @dead2k

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 28 '24 13:06 k8s-ci-robot

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla /easycla

k8s-triage-robot avatar Jun 28 '24 18:06 k8s-triage-robot

/hold To collect reviews.

serathius avatar Jul 01 '24 12:07 serathius

cc @shyamjvs @chaochn47

dims avatar Jul 01 '24 13:07 dims

/lgtm

Thanks

ahrtr avatar Jul 01 '24 13:07 ahrtr

/lgtm

wojtek-t avatar Jul 02 '24 08:07 wojtek-t

@serathius 2 tiny nits, but looks great overall! thanks.

dims avatar Jul 02 '24 12:07 dims

Added backward compatibility as a goal and updated the interface. PTAL @jpbetz @wojtek-t

serathius avatar Jul 05 '24 12:07 serathius

/lgtm

@jpbetz - PTAL

wojtek-t avatar Aug 07 '24 09:08 wojtek-t

/lgtm /approve

jpbetz avatar Sep 23 '24 15:09 jpbetz

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 23 '24 15:09 k8s-ci-robot

It's been almost 3 months without any significant comments. Canceling the hold

/hold cancel

wojtek-t avatar Sep 23 '24 15:09 wojtek-t