enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Kubernetes-etcd interface

Open serathius opened this issue 1 year ago • 1 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Codify the Implicit Kubernetes-ETCD Contract to improve testability, prevent misuse, and streamline future changes.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/4744
  • Discussion Link: https://docs.google.com/document/d/1-nIpoW87qqQ9FxINOzXPkhu7CD_FWW1piYqHZDr39nU/edit?usp=sharing
  • Primary contact (assignee): @serathius
  • Responsible SIGs:
    • SIG-etcd
    • SIG-api-machinery

serathius avatar Jun 28 '24 12:06 serathius

/sig etcd /sig api-machinery

serathius avatar Jun 28 '24 12:06 serathius

/milestone v1.32 /label lead-opted-in

jpbetz avatar Sep 23 '24 15:09 jpbetz

Hi @serathius @jpbetz - enhancements lead here. Is this proposal targeting a specific stage in 1.32? This proposal seems like a bit of a "special snowflake" compared to most and I'm not sure how we should track it.

Thanks!

tjons avatar Sep 29 '24 19:09 tjons

Usually SIG-etcd don't touch K8s meaning that we don't need to adhere to K8s release process, however here it's we are making changes to K8s so I think it's ok to track it.

serathius avatar Oct 03 '24 12:10 serathius

ok - what stage are you targeting in 1.32? alpha/beta/stable?

tjons avatar Oct 04 '24 12:10 tjons

This is the first release for this, so it should be alpha.

jpbetz avatar Oct 04 '24 15:10 jpbetz

@tjons Can you help me compile a list of what we need to have in place for this KEP to make sure it's ready for enhancements freeze? I'm happy with it technically. I see PRR is missing. What else do you see missing from the sig-release checklist?

jpbetz avatar Oct 04 '24 17:10 jpbetz

@jpbetz sorry, just saw this. As we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024, this enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.32.
  • [ ] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday, October 3rd, 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • [ ] KEP status is marked as implementable for latest-milestone: v1.32.
  • [ ] Update the KEP YAML file to comply with the KEP template - there are a number of required sections missing, see https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template.
  • [ ] Add graduation criteria
  • [ ] Complete PRR

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

tjons avatar Oct 06 '24 15:10 tjons

Sorry for confusion, I think we will want to opt-out from this KEP being tracked. Reasons:

  • There is no user facing change, just a refactor to align internal apiserver code to match an interface.
  • We created a KEP just to document the decision and collect consensus.
  • There is no need to broadly announce the change

I thought it would be good to be tracked, as the work will take some time to finish and it would be useful to track progress across multiple K8s versions, however the overhead of KEP template, PRR and other processes makes it not worth it.

serathius avatar Oct 07 '24 12:10 serathius

/milestone-clear

serathius avatar Oct 07 '24 12:10 serathius

Sorry for confusion, I think we will want to opt-out from this KEP being tracked. Reasons:

I agree, this doesn't need PRR. I'm glad we got a good description of our goals and reasoning in the enhancements repo

deads2k avatar Oct 07 '24 21:10 deads2k

Hello @serathius 👋, 1.32 Enhancements team here.

Since this enhancement has been opted out from the current v1.32 milestone, it's now marked as Deferred for the current v1.32 release cycle. Confirming this based on the comment https://github.com/kubernetes/enhancements/issues/4743#issuecomment-2396740504. Thanks!

/remove-label lead-opted-in

dipesh-rawat avatar Oct 10 '24 15:10 dipesh-rawat

/milestone clear

tjons avatar Oct 11 '24 02:10 tjons

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 10 '25 11:01 k8s-triage-robot

/remove-lifecycle stale

serathius avatar Jan 10 '25 11:01 serathius

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 10 '25 12:04 k8s-triage-robot

/remove-lifecycle stale

serathius avatar Apr 10 '25 13:04 serathius

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 09 '25 13:07 k8s-triage-robot

/remove-lifecycle stale /lifecycle frozen

serathius avatar Jul 09 '25 15:07 serathius