kubernetes
KEP-1769/KEP-3570/KEP693: Adding Windows Kubelet Manager implementation details
- One-line PR description: Adding Windows Kubelet Manager implementation details
- Issue link:
- Other comments: This is a follow up to https://github.com/kubernetes/kubernetes/pull/124285#issuecomment-2161327319 to add notes on Windows implementation so we can review and discuss changes/differences.
Related PR: CRI changes: https://github.com/kubernetes/kubernetes/pull/124285 Kubelet changes: https://github.com/kubernetes/kubernetes/pull/125296
/sig node /sig windows
/cc @marosset @aravindhp @knabben @kiashok For sig-windows
/cc @haircommander @mrunalp For sig-node
@kevpar @haircommander We've finalized this from a sig-windows perspective. I've also been able to get the proto-type working in https://github.com/kubernetes/kubernetes/pull/125296 with the proposed changes to containerd @kiashok provided.
Could you take another look?
I would expect this to:
- Add new feature gates
- Add new graduation criteria for those KEPs that are not GA-d yet (ex https://github.com/kubernetes/enhancements/pull/4251)
- Have a test cases section updated
I would expect this to:
- Add new feature gates
- Add new graduation criteria for those KEPs that are not GA-d yet (ex KEP-1769: Graduate Memory Manager to GA #4251)
This was discussed with sig-node awhile back and was agreed that since this can be turned off with cpuManagerPolicy: none we could make the updates here without feature gates. Did this change? @haircommander
https://github.com/kubernetes/kubernetes/pull/124285#issuecomment-2161327319
Have a test cases section updated
I can update the test section with some details as appropriate
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jsturtevant, kevpar, marosset Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
After discussions with sig-node last week, we will break this out into a separate KEP with its own feature flag, this way we can communicate to users that the features are not Stable for windows as well as make it possible for users to opt into the feature.