enhancements
enhancements copied to clipboard
KEP-4322: add CRD scope explanation to alternatives considered section
- One-line PR description: Summarizes context from discussions in SIG-Multicluster meetings and https://docs.google.com/document/d/1E_z3ti-d-modwnhsvR3yBZwX4rRpL26dKkl41YAptRo/edit on why a namespace-scoped CRD is recommended over a cluster-scoped CRD for the ClusterProfile resource.
- Issue link: #4322
- Other comments: Thanks to @thockin for putting together these illustrations of the possible models for cluster inventory topology.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/retest
/retest
/lgtm
@ryanzhang-oss: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/approve
@mikemorris this needs make update-toc, if you don’t mind.
Ah, https://github.com/kubernetes/enhancements/pull/4749 hasn’t been merged, so
/lgtm
/assign @JeremyOT
/lgtm
This still needs an approve: @skitt @JeremyOT - are you still happy with it?
I am still happy with this, and I can now approve, so
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mikemorris, ryanzhang-oss, skitt
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~keps/sig-multicluster/OWNERS~~ [skitt]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment