enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

KEP-4322: add CRD scope explanation to alternatives considered section

Open mikemorris opened this issue 1 year ago • 4 comments

  • One-line PR description: Summarizes context from discussions in SIG-Multicluster meetings and https://docs.google.com/document/d/1E_z3ti-d-modwnhsvR3yBZwX4rRpL26dKkl41YAptRo/edit on why a namespace-scoped CRD is recommended over a cluster-scoped CRD for the ClusterProfile resource.
  • Issue link: #4322
  • Other comments: Thanks to @thockin for putting together these illustrations of the possible models for cluster inventory topology.

mikemorris avatar Jun 04 '24 12:06 mikemorris

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Jun 04 '24 12:06 k8s-ci-robot

/retest

mikemorris avatar Jul 02 '24 20:07 mikemorris

/retest

ryanzhang-oss avatar Jul 23 '24 17:07 ryanzhang-oss

/lgtm

ryanzhang-oss avatar Jul 23 '24 17:07 ryanzhang-oss

@ryanzhang-oss: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 23 '24 17:07 k8s-ci-robot

/approve

@mikemorris this needs make update-toc, if you don’t mind.

skitt avatar Jul 24 '24 14:07 skitt

Ah, https://github.com/kubernetes/enhancements/pull/4749 hasn’t been merged, so

/lgtm

skitt avatar Jul 24 '24 14:07 skitt

/assign @JeremyOT

skitt avatar Jul 24 '24 14:07 skitt

/lgtm

skitt avatar Jul 26 '24 09:07 skitt

This still needs an approve: @skitt @JeremyOT - are you still happy with it?

thockin avatar Sep 09 '24 18:09 thockin

I am still happy with this, and I can now approve, so

/approve

skitt avatar Sep 10 '24 07:09 skitt

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikemorris, ryanzhang-oss, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 10 '24 07:09 k8s-ci-robot