enhancements
enhancements copied to clipboard
KEP-4578: Feature Gate in etcd
- One-line PR description: KEP to introduce feature gate in etcd
- Issue link: https://github.com/kubernetes/enhancements/issues/4578
- Other comments:
/sig etcd
cc @serathius @ahrtr @logicalhan @jmhbnz @fuweid @stackbaek @henrybear327 @wenjiaswe
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: siyuanfoundation Once this PR has been reviewed and has the lgtm label, please ask for approval from serathius. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The initial motivation is only to replace the existing new feature guidance with feature gate, so as to not break anything when graduating a feature.
The cluster level feature is a complicated topic, it's OK to discuss it separately.
/cc @liggitt For feedback about feature gates.
Some small nits, but overall proposal looks good to me.
/lgtm thanks!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jmhbnz, serathius, siyuanfoundation
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~keps/sig-etcd/OWNERS~~ [jmhbnz,serathius]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Overall looks good to me. Thanks @siyuanfoundation for driving the effort.
LGTM. Thanks @siyuanfoundation !