enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

KEP-4578: Feature Gate in etcd

Open siyuanfoundation opened this issue 1 year ago • 2 comments

  • One-line PR description: KEP to introduce feature gate in etcd
  • Issue link: https://github.com/kubernetes/enhancements/issues/4578
  • Other comments:

siyuanfoundation avatar May 02 '24 00:05 siyuanfoundation

/sig etcd

cc @serathius @ahrtr @logicalhan @jmhbnz @fuweid @stackbaek @henrybear327 @wenjiaswe

siyuanfoundation avatar May 02 '24 00:05 siyuanfoundation

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: siyuanfoundation Once this PR has been reviewed and has the lgtm label, please ask for approval from serathius. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 06 '24 18:05 k8s-ci-robot

The initial motivation is only to replace the existing new feature guidance with feature gate, so as to not break anything when graduating a feature.

The cluster level feature is a complicated topic, it's OK to discuss it separately.

ahrtr avatar May 23 '24 15:05 ahrtr

/cc @liggitt For feedback about feature gates.

serathius avatar May 31 '24 12:05 serathius

Some small nits, but overall proposal looks good to me.

serathius avatar Jun 06 '24 12:06 serathius

/lgtm thanks!

wenjiaswe avatar Jun 06 '24 17:06 wenjiaswe

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, serathius, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 08 '24 05:06 k8s-ci-robot

Overall looks good to me. Thanks @siyuanfoundation for driving the effort.

ahrtr avatar Jun 08 '24 12:06 ahrtr

LGTM. Thanks @siyuanfoundation !

fuweid avatar Jun 10 '24 14:06 fuweid