enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

deprecate and remove Kubelet RunOnce mode

Open HirazawaUi opened this issue 1 year ago • 7 comments

  • One-line PR description: Deprecate and remove Kubelet RunOnce mode.
  • Issue link: https://github.com/kubernetes/enhancements/issues/4580
  • Other comments:

HirazawaUi avatar Apr 16 '24 16:04 HirazawaUi

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HirazawaUi Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 16 '24 16:04 k8s-ci-robot

/triage accepted /assign @tallclair

kannon92 avatar Apr 16 '24 21:04 kannon92

Please add a correspond yaml for the prod-readiness. https://github.com/kubernetes/enhancements/tree/master/keps/prod-readiness/sig-node

kannon92 avatar Apr 16 '24 21:04 kannon92

Please add a correspond yaml for the prod-readiness. https://github.com/kubernetes/enhancements/tree/master/keps/prod-readiness/sig-node

But before that, I first need to find a approver....

HirazawaUi avatar Apr 17 '24 16:04 HirazawaUi

@tallclair updated

HirazawaUi avatar May 01 '24 16:05 HirazawaUi

@johnbelamaric @deads2k @jpbetz @wojtek-t Would anyone be willing to become the prr reviewer & approver for this KEP.

HirazawaUi avatar May 01 '24 16:05 HirazawaUi

Thanks @sftim for the suggestion, but there are still some issues that need to wait for the https://github.com/kubernetes/enhancements/pull/4581#discussion_r1597664835 results before modifying them (or not)

HirazawaUi avatar May 14 '24 15:05 HirazawaUi

You are missing the PRR file. Could you please add that? Thanks!

@mrunalp Okay, but I want to know who can be the approver of the prr....

HirazawaUi avatar May 30 '24 14:05 HirazawaUi

@soltysh could you help with this one?

mrunalp avatar May 31 '24 00:05 mrunalp

PRR should be trivial for this. You can just put TBD for the moment.

tallclair avatar Jun 03 '24 17:06 tallclair

@soltysh could you help with this one?

Yup, you can put my name there.

soltysh avatar Jun 04 '24 11:06 soltysh

@mrunalp @tallclair Added PRR file.

HirazawaUi avatar Jun 04 '24 15:06 HirazawaUi

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, mrunalp, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 11 '24 14:06 k8s-ci-robot

/lgtm

mrunalp avatar Jun 12 '24 00:06 mrunalp