enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

KEP-3962: rewrite CEL library section.

Open jiahuif opened this issue 1 year ago • 2 comments

  • One-line PR description: This PR adds information about CEL library changes to MutatingAdmissionPolicy feature.
  • Issue link: https://github.com/kubernetes/enhancements/issues/3962
  • Other comments: This PR removes the question mark from removal operations. Before
mutations:
  - mutaton: >
        Object{
            spec: Object.spec{
                containers: object.spec.containers{
                    object.spec.containers.filter(c, c.name == "sidecar")
                    .map(c, Object.spec.containers.item{
                        ?env: optional.none()
                    })
                }
            }
        }

After

mutations:
  - mutaton: >
        Object{
            spec: Object.spec{
                containers: object.spec.containers{
                    object.spec.containers.filter(c, c.name == "sidecar")
                    .map(c, Object.spec.containers.item{
                        env: optional.none()
                    })
                }
            }
        }

See content for details.

jiahuif avatar Apr 11 '24 23:04 jiahuif

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiahuif Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 11 '24 23:04 k8s-ci-robot

/lgtm I am ok with not using question mark to avoid confusion. Previously we add it mainly for the consideration of field not exist case. With schema check in place, it shouldn't be an concern. Thank you!

cici37 avatar Apr 24 '24 16:04 cici37

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 23 '24 17:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 22 '24 17:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Sep 21 '24 17:09 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 21 '24 17:09 k8s-ci-robot