enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

KEP-4540: Add CPUManager policy option to restrict reservedSystemCPUs to system daemons and interrupt processing #4540

Open jingczhang opened this issue 11 months ago • 29 comments

  • One-line PR description: Adding new KEP
  • Issue link: https://github.com/kubernetes/enhancements/issues/4540
  • Code PR link: https://github.com/kubernetes/kubernetes/pull/123979
  • HTML quick link: https://github.com/nokia/kubernetes-enhancements/tree/4540-strict-cpu-reservation/keps/sig-node/4540-strict-cpu-reservation

jingczhang avatar Mar 07 '24 08:03 jingczhang

Welcome @jingczhang!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Mar 07 '24 08:03 k8s-ci-robot

Hi @jingczhang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 07 '24 08:03 k8s-ci-robot

Initial PR to get reviewers agreement and guidance. Detailed design will be populated after that.

jingczhang avatar Mar 07 '24 08:03 jingczhang

/ok-to-test /cc @ffromani @swatisehgal

bart0sh avatar Mar 13 '24 13:03 bart0sh

Completed the KEP writing. Created the initial kubelet PR to get reviewers comments and guidance. More test cases will be added.

jingczhang avatar Mar 18 '24 21:03 jingczhang

Please run make update-toc to ensure that the Table of Contents is updated based on the content of the enhancement.

swatisehgal avatar Mar 19 '24 12:03 swatisehgal

Updated "RIsks and Mitigations" section for impact on reduced shared pool size. Please review and advise.

jingczhang avatar Mar 21 '24 01:03 jingczhang

/remove-sig apps /remove-sig autoscaling /remove-sig scheduling /remove-sig auth

ffromani avatar Mar 21 '24 15:03 ffromani

I updated the KEP to catch up the discussion on feature risk to make it easier for further review. Please check and advise.

jingczhang avatar Apr 04 '24 14:04 jingczhang

/add-sig scheduling

jingczhang avatar Apr 05 '24 18:04 jingczhang

/sig scheduling

ffromani avatar Apr 17 '24 14:04 ffromani

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jingczhang Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 07 '24 21:05 k8s-ci-robot

@swatisehgal @ffromani I have updated KEP and supporting code to support MinSharedCPUs in Kubelet and 'exclusive-cpu' in NodeAllocatable. Please review and confirm we are aligned. Scheduler change will be added soon.

jingczhang avatar May 07 '24 21:05 jingczhang