enhancements
enhancements copied to clipboard
KEP-4540: Add CPUManager policy option to restrict reservedSystemCPUs to system daemons and interrupt processing #4540
- One-line PR description: Adding new KEP
- Issue link: https://github.com/kubernetes/enhancements/issues/4540
- Code PR link: https://github.com/kubernetes/kubernetes/pull/123979
- HTML quick link: https://github.com/nokia/kubernetes-enhancements/tree/4540-strict-cpu-reservation/keps/sig-node/4540-strict-cpu-reservation
Welcome @jingczhang!
It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/enhancements has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @jingczhang. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Initial PR to get reviewers agreement and guidance. Detailed design will be populated after that.
/ok-to-test /cc @ffromani @swatisehgal
Completed the KEP writing. Created the initial kubelet PR to get reviewers comments and guidance. More test cases will be added.
Please run make update-toc
to ensure that the Table of Contents is updated based on the content of the enhancement.
Updated "RIsks and Mitigations" section for impact on reduced shared pool size. Please review and advise.
/remove-sig apps /remove-sig autoscaling /remove-sig scheduling /remove-sig auth
I updated the KEP to catch up the discussion on feature risk to make it easier for further review. Please check and advise.
/add-sig scheduling
/sig scheduling
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jingczhang Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@swatisehgal @ffromani I have updated KEP and supporting code to support MinSharedCPUs in Kubelet and 'exclusive-cpu' in NodeAllocatable. Please review and confirm we are aligned. Scheduler change will be added soon.